Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dart hotfixes blocked on beta/stable: Flutter engine depends on unstable Windows arm64 Dart SDK #113931

Closed
athomas opened this issue Oct 24, 2022 · 6 comments
Closed

Dart hotfixes blocked on beta/stable: Flutter engine depends on unstable Windows arm64 Dart SDK #113931

athomas opened this issue Oct 24, 2022 · 6 comments
Assignees
@godofredoc
Labels
team-infra Owned by Infrastructure team

Comments

@athomas
Copy link
Contributor

athomas commented Oct 24, 2022

The Flutter Engine depends on the unstable Dart SDK for Windows ARM64:
https://github.com/flutter/engine/blob/6bb2f03e6fd00b440e6ab2e20ad94b8104cc12e7/DEPS#L398

This SDK was never meant to be published on beta and stable channels. Dart has recently changed the release tooling to no longer produce these SDKs on beta and stable. The same will apply to Linux RISCV SDKs but those are currently not used by Flutter.

Now Flutter can no longer receive beta and stable hotfixes from Dart because they are missing the Windows ARM64 SDKs. Dart 2.18.3 was not included in the latest Flutter hotfix because of this issue.

/cc @godofredoc @itsjustkevin @mit-mit
@athomas athomas added the team-infra Owned by Infrastructure team label Oct 24, 2022
@mit-mit
Copy link
Member

mit-mit commented Oct 24, 2022

looks like this is from https://github.com/flutter/engine/pull/33681/files, cc @zanderso

@zanderso
Copy link
Member

@cbracken is this safe to remove from Flutter master channel, or will it break folks working on/with Flutter Windows ARM64 support?

@cbracken
Copy link
Member

cbracken commented Oct 24, 2022 •
edited

From a separate chat this morning with @timsneath @godofredoc it sounds like this should be alright on master channel, but problematic to build on beta/stable channels. Is that the case?

It would be good to have the option to build for arm64 Windows on master until we've got to the point where we're able to properly support this with build/devicelab hardware (and co-ordination with the Dart SDK side of things as well).

@godofredoc godofredoc self-assigned this Oct 24, 2022
@godofredoc godofredoc mentioned this issue Oct 24, 2022
Merged
8 tasks
@athomas
Copy link
Contributor Author

athomas commented Oct 25, 2022

From a separate chat this morning with @timsneath @godofredoc it sounds like this should be alright on master channel, but problematic to build on beta/stable channels. Is that the case?

It would be good to have the option to build for arm64 Windows on master until we've got to the point where we're able to properly support this with build/devicelab hardware (and co-ordination with the Dart SDK side of things as well).

That's correct. Note that we might transition arm64 Windows to beta at some point before shipping it on stable.

@godofredoc godofredoc mentioned this issue Oct 28, 2022
Closed
pbo-linaro pushed a commit to pbo-linaro/flutter-recipes that referenced this issue Nov 24, 2022
@godofredoc
Pass release_candidate branch to gclient for releases.
4b55106 
This is to allow gclient to filter out dependencies available only on
main channels during release candidate builds.

Bug: flutter/flutter#113931
Change-Id: I175e07a7c426709933954990dc9b41cbccd4c110
Reviewed-on: https://flutter-review.googlesource.com/c/recipes/+/35080
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Godofredo Contreras <godofredoc@google.com>
@godofredoc godofredoc mentioned this issue Mar 23, 2023
Merged
8 tasks
@godofredoc
Copy link
Contributor

closing this as complete. The arm64 artifacts are now built in their own build and running it or not on release branches is controlled from .ci.yaml file.

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@godofredoc godofredoc

Labels
team-infra Owned by Infrastructure team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@cbracken @zanderso @mit-mit @athomas @godofredoc