Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation post-submit builders to dart-internal #115486

Closed
drewroengoogle opened this issue Nov 16, 2022 · 2 comments
Closed

Add documentation post-submit builders to dart-internal #115486

drewroengoogle opened this issue Nov 16, 2022 · 2 comments
Labels
team-infra Owned by Infrastructure team

Comments

@drewroengoogle
Copy link
Contributor

No description provided.

@drewroengoogle drewroengoogle added the team-infra Owned by Infrastructure team label Nov 16, 2022
pbo-linaro pushed a commit to pbo-linaro/flutter-recipes that referenced this issue Dec 1, 2022
@yusuf-goog
Adding repository field to engine.proto
5fc2b63 
This field is necessary to create a generic
release builder recipe.

Bug:flutter/flutter#115486
Change-Id: Id9aaa0a01ad1f93b5e8eaf9084eaac874ac5c5e7
Reviewed-on: https://flutter-review.googlesource.com/c/recipes/+/36722
Reviewed-by: Godofredo Contreras <godofredoc@google.com>
Commit-Queue: Godofredo Contreras <godofredoc@google.com>
pbo-linaro pushed a commit to pbo-linaro/flutter-recipes that referenced this issue Dec 6, 2022
@yusuf-goog
Fixing format issue in string concatation.
a4bff0c 
Fixing formatting issue in adhoc_validation string
concatenation when value is None.

Bug:flutter/flutter#115486
Change-Id: Ie14e1f5f29cd2e34a65f3d1fa573713e904a55ce
Reviewed-on: https://flutter-review.googlesource.com/c/recipes/+/36820
Commit-Queue: Yusuf Mohsinally <mohsinally@google.com>
Reviewed-by: Godofredo Contreras <godofredoc@google.com>
@sealesj
Copy link
Contributor

sealesj commented Dec 8, 2022

Completed with https://critique.corp.google.com/cl/493673654

@sealesj sealesj closed this as completed Dec 8, 2022
@github-actions
Copy link

github-actions bot commented Mar 5, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
team-infra Owned by Infrastructure team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@drewroengoogle @sealesj