Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[web] Cleanup: HostNodes #116204

Closed
ditman opened this issue Nov 29, 2022 · 3 comments · Fixed by flutter/engine#39915
Closed

[web] Cleanup: HostNodes #116204

ditman opened this issue Nov 29, 2022 · 3 comments · Fixed by flutter/engine#39915
Labels
c: tech-debt Technical debt, code quality, testing, etc. engine flutter/engine repository. See also e: labels. P3 Issues that are less important to the Flutter project platform-web Web applications specifically

Comments

@ditman
Copy link
Member

ditman commented Nov 29, 2022

Flutter has a rendering mode where it puts all its contents in a regular DOM element when the ShadowDOM API is not supported.

This was implemented for Stadia, but now that it's sadly not needed, it can maybe be cleaned up.

Proposal

Completely delete lib/web_ui/lib/src/engine/host_node.dart, then fix whatever fails where that type is used. Substitute this by a standard DomShadowRoot type (from dom.dart).
@ditman ditman added engine flutter/engine repository. See also e: labels. platform-web Web applications specifically P3 Issues that are less important to the Flutter project c: tech-debt Technical debt, code quality, testing, etc. labels Nov 29, 2022
@ditman ditman mentioned this issue Nov 29, 2022
Merged
8 tasks
@ditman
Copy link
Member Author

ditman commented Nov 29, 2022 •
edited
Loading

Does this break the ability of Cobalt to render Flutter web apps?

@ditman
Copy link
Member Author

ditman commented Dec 15, 2022

Follow up of: flutter/engine#37738

This was referenced Feb 24, 2023
Merged
Merged
auto-submit bot pushed a commit to flutter/engine that referenced this issue Apr 19, 2023
@mdebbar
[web] Remove non-ShadowDom mode (#39915)
d626f16 
If we still want to do this, here's a quick PR :)

Fixes flutter/flutter#116204
@github-actions
Copy link

github-actions bot commented May 3, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
c: tech-debt Technical debt, code quality, testing, etc. engine flutter/engine repository. See also e: labels. P3 Issues that are less important to the Flutter project platform-web Web applications specifically
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[web] Remove non-ShadowDom mode mdebbar/engine
1 participant
@ditman