Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Impeller] Partially update and reuse glyph atlases across render passes. #116815

Closed
chinmaygarde opened this issue Dec 10, 2022 · 4 comments
Closed

[Impeller] Partially update and reuse glyph atlases across render passes. #116815

chinmaygarde opened this issue Dec 10, 2022 · 4 comments
Assignees
@jonahwilliams
Labels
c: performance Relates to speed or footprint issues (see "perf:" labels) e: impeller Impeller rendering backend issues and features requests engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list
Milestone
Impeller on iOS

Comments

@chinmaygarde
Copy link
Member

chinmaygarde commented Dec 10, 2022 •
edited
Loading

Today, glyph atlases are created per render pass and discarded immediately after. This causes a lot of churn and the primary performance bottleneck in rendering text heavy applications using Impeller.

Impeller should be able to reuse glyph atlases across multiple render passes.
@chinmaygarde chinmaygarde added engine flutter/engine repository. See also e: labels. c: performance Relates to speed or footprint issues (see "perf:" labels) P2 Important issues not at the top of the work list e: impeller Impeller rendering backend issues and features requests labels Dec 10, 2022
@chinmaygarde chinmaygarde added this to the Impeller on iOS milestone Dec 10, 2022
@chinmaygarde chinmaygarde mentioned this issue Dec 10, 2022
Closed
@luckysmg luckysmg mentioned this issue Dec 13, 2022
Merged
8 tasks
@jonahwilliams jonahwilliams mentioned this issue Dec 13, 2022
Merged
@jonahwilliams
Copy link
Member

Fixed via flutter/engine#38253

@jonahwilliams jonahwilliams reopened this Feb 3, 2023
@jonahwilliams
Copy link
Member

Reopening because flutter/engine#38244 or similar would be required when platform views are involved

@jonahwilliams
Copy link
Member

From discussion, we sort of decided that would be the wrong approach. I'm going to close this for now as I think we've covered the obvious cases, and if we see any future instances of performance problems due to glyph atlas churn we can use those to think up new ideas.

@github-actions
Copy link

github-actions bot commented Mar 3, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jonahwilliams jonahwilliams

Labels
c: performance Relates to speed or footprint issues (see "perf:" labels) e: impeller Impeller rendering backend issues and features requests engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list
Projects
No open projects
Impeller
Archived in project
Milestone
Impeller on iOS
Development

No branches or pull requests
2 participants
@chinmaygarde @jonahwilliams