NavigationRail isExtended:true destination label highlight has the wrong width

[HansMuller]

The destination label highlight for a M3 NavigationRail with isExtended:true has the wrong width or the wrong origin.

This is a regression for useMaterial3:true. It's possible (I haven't checked) that it was introduced in #116108.

Here's an example that demonstrates the problem: https://dartpad.dev/?id=272d62da895a9e17c38c7f562a6d3d5f&channel=master

[HansMuller]

CC @darrenaustin
A fix for this may need to be cherry-picked

[TahaTesser]

Apologies, I'm working on this. I'm also accounting for custom padding from destinations which also messes up highlight position.

Maybe get rid of the _IndicatorInkWell class and move InkResponse to the indicator itself and wrap a custom render box with expands hitTest area of the destination.
Something that chip.dart has:
https://github.com/flutter/flutter/blob/dbc9306380d8a72273b478b8fcc934a6014f946d/packages/flutter/lib/src/material/chip.dart#LL1332C17-L1332C17

This doesn't work without refactoring a whole lot of code.

A better getRectCallback is needed that use the exact position of the NavigationIndicator.

[Piinks]

I haven't been able to reproduce this yet. I wonder if there is more than one bug here. Going to the dartpad link above does not look like it is actually using material 3.

[TahaTesser]

This should be reproducible on the beta channel. The current stable doesn't have this

[Piinks]

Yeah I have it running on master, and for some reason dartpad wont let me change the channel using the button at the bottom

[TahaTesser]

I've attempted to fix this issue: #117320 and added regression tests.

Unrelated to this regression, after the holidays, I want to streamline the NavigationRail class, it's not as clean and flexible as the new NavigationBar.

1. It doesn't have a smarter destination rendering. Everything is rendered in a column with lots of SizedBox widgets.
2. minWidth and minExtendedWidth behave weirdly.
3. It could also fix: [Proposal] Find a way to reuse code fron NavigationDestination for widgets other than NavigationBar  #104813 NavigationRailDestination in selected mode doesn't shift in M3 #116298

[Piinks]

Thanks @TahaTesser!

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.