Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP] Fix NavigationRail highlight #117340

Closed
Piinks opened this issue Dec 19, 2022 · 4 comments
Closed

[CP] Fix NavigationRail highlight #117340

Piinks opened this issue Dec 19, 2022 · 4 comments
Labels
cp: approved Approved cherry-pick request cp: merge-to-beta Cherry-picks that should be merged to beta cp: review Cherry-picks in the review queue

Comments

@Piinks
Copy link
Contributor

Piinks commented Dec 19, 2022 •
edited by itsjustkevin

issue_link

#117126

Commit Hash

5fcb48d

Target

beta

pr_link

#117344

Impacted Users

Users of the Material 3 spec

Impact Description

This fixed a regression introduced in #116108
The new Material 3 NavigationRail was rendering the highlight in the wrong location.

image

Workaround

No.

Risk

low

Test Coverage

yes

Validation Steps

This dartpad reproduced the issue. https://dartpad.dev/?id=272d62da895a9e17c38c7f562a6d3d5f&channel=master
@Piinks Piinks added the cp: review Cherry-picks in the review queue label Dec 19, 2022
@itsjustkevin
Copy link
Contributor

@HansMuller could you check out this cherry-pick request?

@HansMuller
Copy link
Contributor

LGTM

@itsjustkevin itsjustkevin added cp: approved Approved cherry-pick request cp: merge-to-beta Cherry-picks that should be merged to beta labels Dec 19, 2022
@Piinks Piinks mentioned this issue Dec 19, 2022
Merged
@Piinks
Copy link
Contributor Author

Piinks commented Dec 19, 2022

Cherry pick PR is #117344

@itsjustkevin itsjustkevin mentioned this issue Jan 4, 2023
Merged
@github-actions
Copy link

github-actions bot commented Mar 4, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
cp: approved Approved cherry-pick request cp: merge-to-beta Cherry-picks that should be merged to beta cp: review Cherry-picks in the review queue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@HansMuller @itsjustkevin @Piinks