Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for opting out of enter route snapshotting in zoom page transition #117917

Closed
jonahwilliams opened this issue Jan 3, 2023 · 3 comments
Assignees
Labels
c: new feature Nothing broken; request for a new capability c: proposal A detailed proposal for a change to Flutter customer: money (g3) framework flutter/packages/flutter repository. See also f: labels. P2 Important issues not at the top of the work list

Comments

@jonahwilliams
Copy link
Member

This may require a small breaking change to the route settings API. We could potentially CP this but I'll need to investigate first

@jonahwilliams jonahwilliams added c: new feature Nothing broken; request for a new capability customer: money (g3) P2 Important issues not at the top of the work list labels Jan 3, 2023
@jonahwilliams jonahwilliams self-assigned this Jan 3, 2023
@Time1ess
Copy link
Contributor

Time1ess commented Jan 3, 2023

IMHO, I wonder if it's OK to add this option to the zoom page transition builder object itself, then we may not need breaking change while enable global opt-out instead of per-page opt-out. E.g

const ZoomPageTransitionsBuilder({
  this.enableEnterPageSnapshotting = true,
});

  final bool enableEnterPageSnapshotting;

@darshankawar darshankawar added framework flutter/packages/flutter repository. See also f: labels. c: proposal A detailed proposal for a change to Flutter labels Jan 24, 2023
@jonahwilliams
Copy link
Member Author

This was done

@github-actions
Copy link

github-actions bot commented Mar 3, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
c: new feature Nothing broken; request for a new capability c: proposal A detailed proposal for a change to Flutter customer: money (g3) framework flutter/packages/flutter repository. See also f: labels. P2 Important issues not at the top of the work list
Projects
None yet
Development

No branches or pull requests

3 participants