Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CP] [Impeller] Make text glyph offsets respect the current transform #119183

Closed
zanderso opened this issue Jan 25, 2023 · 3 comments
Closed

[CP] [Impeller] Make text glyph offsets respect the current transform #119183

zanderso opened this issue Jan 25, 2023 · 3 comments
Assignees
Labels
cp: approved Approved cherry-pick request cp: merge-to-stable Cherry-picks that should be merged to stable cp: review Cherry-picks in the review queue

Comments

@zanderso
Copy link
Member

issue_link

#117428

Commit Hash

flutter/engine@30c02e4

Target

stable

pr_link

flutter/engine#39140

Impacted Users

Impeller users transforming text

Impact Description

Impeller text rendering does not respect transforms, which causes text to look not as intended.

Workaround

There is no workaround.

Risk

low

Test Coverage

yes

Validation Steps

Before the fix transforms will not be applied to text. After the fix transforms will be applied to text.

@zanderso zanderso added the cp: review Cherry-picks in the review queue label Jan 25, 2023
@zanderso
Copy link
Member Author

cc @chinmaygarde @bdero

@bdero
Copy link
Member

bdero commented Jan 25, 2023

lgtm 👍

@CaseyHillers CaseyHillers added cp: approved Approved cherry-pick request cp: merge-to-stable Cherry-picks that should be merged to stable labels Jan 26, 2023
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cp: approved Approved cherry-pick request cp: merge-to-stable Cherry-picks that should be merged to stable cp: review Cherry-picks in the review queue
Projects
None yet
Development

No branches or pull requests

4 participants