Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CP] [Impeller] Blurry text fixes #119292

Closed
zanderso opened this issue Jan 26, 2023 · 7 comments
Closed

[CP] [Impeller] Blurry text fixes #119292

zanderso opened this issue Jan 26, 2023 · 7 comments
Assignees
Labels
cp: approved Approved cherry-pick request cp: merge-to-stable Cherry-picks that should be merged to stable cp: review Cherry-picks in the review queue

Comments

@zanderso
Copy link
Member

issue_link

#118613

Commit Hash

flutter/engine@5405f2c

Target

stable

pr_link

flutter/engine#39180

Impacted Users

Impeller users

Impact Description

Text is blurry relative to the old renderer.

Workaround

There is no workaround

Risk

low

Test Coverage

yes

Validation Steps

In any app, before the fixes, text is blurry. After the fixes, text looks on par with the old renderer.

@zanderso zanderso added the cp: review Cherry-picks in the review queue label Jan 26, 2023
@zanderso
Copy link
Member Author

@jonahwilliams
Copy link
Member

LGTM, but we also need the rotated text fix too

@zanderso
Copy link
Member Author

zanderso commented Jan 26, 2023

The CP PR contains both flutter/engine@5405f2c and flutter/engine@55bb8de. Were there any more?

@jonahwilliams
Copy link
Member

ahh, that's good.

As long as we're on it though, you might want to grab the text transform fix too? flutter/engine#39119

@zanderso
Copy link
Member Author

There's a separate CP issue for that here #119183

@jonahwilliams
Copy link
Member

perfect!

@github-actions
Copy link

github-actions bot commented Mar 3, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cp: approved Approved cherry-pick request cp: merge-to-stable Cherry-picks that should be merged to stable cp: review Cherry-picks in the review queue
Projects
None yet
Development

No branches or pull requests

4 participants