Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP] NavigationBar ink ripple fixes #119554

Closed
Piinks opened this issue Jan 30, 2023 · 3 comments
Closed

[CP] NavigationBar ink ripple fixes #119554

Piinks opened this issue Jan 30, 2023 · 3 comments
Assignees
@XilaiZhang
Labels
cp: approved Approved cherry-pick request cp: merge-to-stable Cherry-picks that should be merged to stable cp: review Cherry-picks in the review queue

Comments

@Piinks
Copy link
Contributor

Piinks commented Jan 30, 2023 •
edited

issue_link

#117420

Commit Hash

74645b4

Target

stable

pr_link

#119553

Impacted Users

All M3 users

Impact Description

This fixes an issue with ink ripple alignment with the navigation bar when using Material 3.

In order to pick this commit, another previously cherry pick needed to be included: #117500

Workaround

No.

Risk

low

Test Coverage

yes

Validation Steps

The runnable example on https://master-api.flutter.dev/flutter/material/NavigationBar-class.html shows the issue, with this fix it no longer reproduces.
@Piinks Piinks added the cp: review Cherry-picks in the review queue label Jan 30, 2023
@Piinks Piinks mentioned this issue Jan 30, 2023
Merged
8 tasks
@CaseyHillers
Copy link
Contributor

@HansMuller can you review this CP request?

@HansMuller
Copy link
Contributor

LGTM

@CaseyHillers CaseyHillers added the cp: approved Approved cherry-pick request label Jan 30, 2023
@rydmike rydmike mentioned this issue Jan 31, 2023
Closed
@CaseyHillers CaseyHillers added the cp: merge-to-stable Cherry-picks that should be merged to stable label Feb 6, 2023
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@XilaiZhang XilaiZhang

Labels
cp: approved Approved cherry-pick request cp: merge-to-stable Cherry-picks that should be merged to stable cp: review Cherry-picks in the review queue
Projects
No open projects
Material 3
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
5 participants
@HansMuller @CaseyHillers @Piinks @XilaiZhang @godofredoc