New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry pick NavigationBar ink ripple fixes #119553
Conversation
@Piinks |
Umm I did a rerun of the presubmit tests but seem like they are still failing |
Yeah I am not sure what the issue is, there are a number of errors that have to do with unnamed library?
I am not used to cherry picking, I'll try to take another look later today. |
Thanks for checking Micheal! We are releasing tomorrow morning, would Kate’s CP be able to make it tonight to pass the presubs? |
We will probably save this cp for the next hotfix, since we are about to release tomorrow morning |
Co-authored-by: Michael Goderbauer <goderbauer@google.com>
Thanks, should be fixed with latest commit |
Landing with customer_testing failures as they are not expected to pass consistently on release candidate branches. |
…#3180) * 200bc35ec Make gen-l10n error handling independent of logger state (#119644) (flutter/flutter#119679) * 7c2870772 cherrypick fix to dwds (flutter/flutter#119745) * 80f3571a8 check if directory exists before listing content (#119748) (flutter/flutter#119946) * 78d09b68d Do not run customer testing on release candidate branches. (#119979) (flutter/flutter#119984) * c6ab0a013 Cherry pick NavigationBar ink ripple fixes (flutter/flutter#119553) * 22908563c Verify Mac artifact codesigning on x64 and arm64 (flutter/flutter#120153) * 32fb2f948 Update Engine revision to f40b73f8a4d5bc2bf50b21e3c0fb478b8f282486 for stable release 3.7.2 (flutter/flutter#120263)
Pick for: #119554
Main goal to cherry pick: #117473
Required pulling in already cherry picked: #117500
There were some conflicts based on a lot of changes in this file over the last month, some cherry picked, others not, can you check me on this @TahaTesser?
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.