flutter create --template=package creates platform folders #119844

thisisyusub · 2023-02-02T18:45:18Z

Steps to Reproduce

Execute flutter create --template=package package_name

Expected results:
When we create package, I assume that it should only create dart files.

Actual results:
But unfortunately, it creates all platform folders - android, ios, macos and etc. I have tried to create package from Android studio, VS Code and even with flutter command.

Logs

// this is modular app (contains different flutter packages, web and android/ios app)
Analyzing Inside...                                                     
No issues found! (ran in 3.3s)

[✓] Flutter (Channel stable, 3.7.0, on macOS 13.1 22C65 darwin-arm64 (Rosetta),
    locale en-AZ)
    • Flutter version 3.7.0 on channel stable at
      /Users/kanza/Development/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision b06b8b2710 (10 days ago), 2023-01-23 16:55:55 -0800
    • Engine revision b24591ed32
    • Dart version 2.19.0
    • DevTools version 2.20.1

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.1)
    • Android SDK at /Users/kanza/Library/Android/sdk
    • Platform android-33, build-tools 33.0.1
    • Java binary at: /Users/kanza/Library/Application
      Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/221.6008.13.2211.9477386
      /Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      11.0.15+0-b2043.56-8887301)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.2)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14C18
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.1)
    • Android Studio at /Users/kanza/Library/Application
      Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/221.6008.13.2211.9477386
      /Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build
      11.0.15+0-b2043.56-8887301)

[!] Android Studio
    • Android Studio at /Users/kanza/Desktop/Android Studio Preview.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    ✗ Unable to find bundled Java version.
    • Try updating or re-installing Android Studio.

[✓] IntelliJ IDEA Community Edition (version 2022.3.2)
    • IntelliJ at /Users/kanza/Library/Application
      Support/JetBrains/Toolbox/apps/IDEA-C/ch-0/223.8617.56/IntelliJ IDEA
      CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.74.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.58.0

The text was updated successfully, but these errors were encountered:

lucamenor · 2023-02-02T20:45:43Z

Same problem here.

guidezpl · 2023-02-02T20:50:23Z

Related #116320

Terranic · 2023-02-02T21:04:21Z

They may be needed in case of platform dependent code (e.g. platform channels) -- don´t they? So a full template needs to setup all platform folders.

guidezpl · 2023-02-02T22:15:13Z

They may be needed in case of platform dependent code (e.g. platform channels) -- don´t they? So a full template needs to setup all platform folders.

That would be true for plugins, which are effectively packages + native code. Packages are generally pure Dart.

maRci002 · 2023-02-02T22:50:18Z

Minimal dart package:
dart create --template=package my_package

You can add flutter sdk in pubspec.yaml

dependencies:
  flutter:
    sdk: flutter

darshankawar · 2023-02-03T07:21:11Z

Thanks for the report. Seeing same behavior as reported.

This document gives overview of some of the files generated using the said command, but nothing much on the folders created with it.

With this though for plugin to create, we specify platforms for which the plugin need to support and hence the respective folders are created.

stable, master flutter doctor -v

[!] Flutter (Channel stable, 3.7.0, on macOS 12.2.1 21D62 darwin-x64, locale
    en-GB)
    • Flutter version 3.7.0 on channel stable at
      /Users/dhs/documents/fluttersdk/flutter
    ! Warning: `flutter` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/flutter, which is not inside
      your current Flutter SDK checkout at
      /Users/dhs/documents/fluttersdk/flutter. Consider adding
      /Users/dhs/documents/fluttersdk/flutter/bin to the front of your path.
    ! Warning: `dart` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/dart, which is not inside your
      current Flutter SDK checkout at /Users/dhs/documents/fluttersdk/flutter.
      Consider adding /Users/dhs/documents/fluttersdk/flutter/bin to the front
      of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision b06b8b2710 (28 hours ago), 2023-01-23 16:55:55 -0800
    • Engine revision b24591ed32
    • Dart version 2.19.0
    • DevTools version 2.20.1
    • If those were intentional, you can disregard the above warnings; however
      it is recommended to use "git" directly to perform update checks and
      upgrades.

[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (5 available)
    • SM G975F (mobile)       • RZ8M802WY0X • android-arm64   • Android 11 (API 30)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

[!] Flutter (Channel master, 3.8.0-3.0.pre.20, on macOS 12.2.1 21D62 darwin-x64,
    locale en-GB)
    • Flutter version 3.8.0-3.0.pre.20 on channel master at
      /Users/dhs/documents/fluttersdk/flutter
    ! Warning: `flutter` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/flutter, which is not inside
      your current Flutter SDK checkout at
      /Users/dhs/documents/fluttersdk/flutter. Consider adding
      /Users/dhs/documents/fluttersdk/flutter/bin to the front of your path.
    ! Warning: `dart` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/dart, which is not inside your
      current Flutter SDK checkout at /Users/dhs/documents/fluttersdk/flutter.
      Consider adding /Users/dhs/documents/fluttersdk/flutter/bin to the front
      of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision bc45b18589 (2 hours ago), 2023-02-02 21:37:03 -0500
    • Engine revision 2696fff871
    • Dart version 3.0.0 (build 3.0.0-196.0.dev)
    • DevTools version 2.21.1
    • If those were intentional, you can disregard the above warnings; however
      it is recommended to use "git" directly to perform update checks and
      upgrades.

[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (5 available)
    • SM G975F (mobile)       • RZ8M802WY0X • android-arm64   • Android 11 (API 30)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

thisisyusub · 2023-02-05T20:02:36Z

Thanks for comments.
@darshankawar so I understood it is okay for packages to generate different platform packages, right?

thisisyusub · 2023-02-05T20:06:37Z

Minimal dart package: dart create --template=package my_package

You can add flutter sdk in pubspec.yaml
dependencies:
  flutter:
    sdk: flutter

Yes this is true but this package can't depend on Flutter related things (for example, creating any feature ui with material and cupertino components in this package and so on), but in the normal case we would create package that can use Flutter related codes too.

christopherfujino · 2023-02-07T21:20:01Z

Although I didn't know about this template, it seems a valid use case where you want to author a package that calls dart:ui.

eximius313 · 2023-02-20T08:37:35Z

if this platform specific packages are supposed to be generated, please allow at least to configure them via --platforms, because not everybody needs every platform

Rexios80 · 2023-03-15T22:29:05Z

The package template has always been to create reusable dart-only flutter code. Adding platform-specific files would make the project a plugin instead. This template only recently started generating platform folders. The files generated seem to be files that would be ignored anyways even if they were supposed to be there. Except they aren't ignored because this template isn't supposed to be generating them.

abdulrojakdev · 2023-04-14T08:09:22Z

Same problem here.

`package` template should not create platform folders. This happen cause by default all platforms are supported and tools didn't distinguish between package and other template, which makes all platforms are true for below code, https://github.com/flutter/flutter/blob/d186792c00f61149916f685e2975300342f64749/packages/flutter_tools/lib/src/project.dart#L374-L380 fixes: #119844 which make #116320 makes invalid. As for why tools created deprecated `Android Embedding`, `appManifestFile` does not exist for `package` template, which make below code to trigger, https://github.com/flutter/flutter/blob/master/packages/flutter_tools/lib/src/project.dart#L768-L770 This does not happen with `module` and `plugin` as it have specific condition check for them. I try to reproduce it with `app` template but didn't succeed

abdulrojakdev · 2023-05-11T07:13:15Z

why is this issue not resolved in Flutter version 3.10.0 ?

christopherfujino · 2023-05-12T20:43:38Z

why is this issue not resolved in Flutter version 3.10.0 ?

because it was merged after Flutter 3.10 branched. See https://github.com/flutter/flutter/wiki/Where%27s-my-commit%3F for more context.

flutter/flutter#119844

github-actions · 2023-05-26T21:00:49Z

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

darshankawar added the in triage Presently being triaged by the triage team label Feb 3, 2023

christopherfujino added the P3 Issues that are less important to the Flutter project label Feb 7, 2023

darshankawar mentioned this issue Feb 17, 2023

"flutter create --template=package" outputs platform folders #120941

Closed

darshankawar mentioned this issue Apr 6, 2023

flutter create -t package creates platform specific folders #124279

Closed

2 tasks

Anas35 mentioned this issue Apr 21, 2023

fix package template create platform folders #125292

Merged

8 tasks

auto-submit bot closed this as completed in #125292 Apr 29, 2023

darshankawar added the r: fixed Issue is closed as already fixed in a newer version label May 2, 2023

rk0cc added a commit to rk0cc/intl_script_recognizer that referenced this issue May 13, 2023

Remove platform file

18a86f8

flutter/flutter#119844

dam-ease mentioned this issue May 25, 2023

flutter create --template=package create directories for all platforms #127491

Closed

2 tasks

github-actions bot locked as resolved and limited conversation to collaborators May 26, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

flutter create --template=package creates platform folders #119844

flutter create --template=package creates platform folders #119844

thisisyusub commented Feb 2, 2023

lucamenor commented Feb 2, 2023

guidezpl commented Feb 2, 2023

Terranic commented Feb 2, 2023

guidezpl commented Feb 2, 2023

maRci002 commented Feb 2, 2023

darshankawar commented Feb 3, 2023

thisisyusub commented Feb 5, 2023

thisisyusub commented Feb 5, 2023

christopherfujino commented Feb 7, 2023

eximius313 commented Feb 20, 2023

Rexios80 commented Mar 15, 2023

abdulrojakdev commented Apr 14, 2023

abdulrojakdev commented May 11, 2023

christopherfujino commented May 12, 2023 •

edited

github-actions bot commented May 26, 2023

flutter create --template=package creates platform folders #119844

flutter create --template=package creates platform folders #119844

Comments

thisisyusub commented Feb 2, 2023

Steps to Reproduce

lucamenor commented Feb 2, 2023

guidezpl commented Feb 2, 2023

Terranic commented Feb 2, 2023

guidezpl commented Feb 2, 2023

maRci002 commented Feb 2, 2023

darshankawar commented Feb 3, 2023

thisisyusub commented Feb 5, 2023

thisisyusub commented Feb 5, 2023

christopherfujino commented Feb 7, 2023

eximius313 commented Feb 20, 2023

Rexios80 commented Mar 15, 2023

abdulrojakdev commented Apr 14, 2023

abdulrojakdev commented May 11, 2023

christopherfujino commented May 12, 2023 • edited

github-actions bot commented May 26, 2023

christopherfujino commented May 12, 2023 •

edited