Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[camerax] Implement resolution configuration #120462

Closed
camsim99 opened this issue Feb 10, 2023 · 4 comments · Fixed by flutter/packages#3799
Closed

[camerax] Implement resolution configuration #120462

camsim99 opened this issue Feb 10, 2023 · 4 comments · Fixed by flutter/packages#3799
Assignees
@camsim99
Labels
c: new feature Nothing broken; request for a new capability c: proposal A detailed proposal for a change to Flutter p: camera The camera plugin P2 Important issues not at the top of the work list package flutter/packages repository. See also p: labels. platform-android Android applications specifically r: fixed Issue is closed as already fixed in a newer version team-android Owned by Android platform team triaged-android Triaged by Android platform team
Projects
Android Camera Re-write

Comments

@camsim99
Copy link
Contributor

camsim99 commented Feb 10, 2023 •
edited

With the camera plugin, developers are able to specify a ResolutionPreset to choose a resolution for the camera images, preview, and video recording (see source). In addition, onCameraResolutionChanged(int cameraId) is used to listen for changes in camera resolution (see source).

Both of these will need to be implemented in the CameraX plugin.
@camsim99 camsim99 added c: new feature Nothing broken; request for a new capability platform-android Android applications specifically plugin p: camera The camera plugin c: proposal A detailed proposal for a change to Flutter P2 Important issues not at the top of the work list labels Feb 10, 2023
@iakmds
Copy link

iakmds commented Feb 11, 2023

Thank you for your efforts @camsim99, I can't wait to try out CameraX.

Regarding the resolution configuration, will it be possible to select a custom resolution apart from the presets we already have? There is also an issue (#45665) about this; I believe this is a much requested feature. Thanks again!

@camsim99
Copy link
Contributor Author

Regarding the resolution configuration, will it be possible to select a custom resolution apart from the presets we already have? There is also an issue (#45665) about this; I believe this is a much requested feature. Thanks again!

@iakmds thank you for pointing this out! I will track this issue to see if this is something a feature we may want to support, likely once the CameraX plugin is completed.

@iakmds
Copy link

iakmds commented Feb 23, 2023

On a side note, in case it is out of the scope to select a fully custom resolution, maybe it should be considered to get a list of all resolution presets that the specific camera supports, something like this:

resolutions

@iakmds iakmds mentioned this issue Feb 25, 2023
Closed
@camsim99 camsim99 self-assigned this Mar 22, 2023
@camsim99 camsim99 moved this from To do to In progress in Android Camera Re-write Apr 22, 2023
@camsim99 camsim99 mentioned this issue Apr 22, 2023
Merged
11 tasks
@camsim99 camsim99 mentioned this issue May 2, 2023
Merged
11 tasks
@camsim99 camsim99 mentioned this issue Jun 26, 2023
Closed
@flutter-triage-bot flutter-triage-bot bot added the package flutter/packages repository. See also p: labels. label Jul 5, 2023
@Hixie Hixie removed the plugin label Jul 6, 2023
@flutter-triage-bot flutter-triage-bot bot added multiteam-retriage-candidate team-android Owned by Android platform team triaged-android Triaged by Android platform team labels Jul 8, 2023
@camsim99 camsim99 mentioned this issue Jul 19, 2023
Merged
11 tasks
auto-submit bot pushed a commit to flutter/packages that referenced this issue Jul 27, 2023
@camsim99
[camerax] Wrap classes to implement resolution configuration for imag…
897f695 
…e capture, image analysis, and preview (#4523)

Wraps classes to implement resolution configuration for image capture, image analysis, and preview. Also bumps CameraX version to latest and removes the deprecated classes used previously.

No functionality changes. Also thanks to @bparrishMines who did majority of the work here!

Part of flutter/flutter#120462
@camsim99 camsim99 mentioned this issue Jul 31, 2023
Merged
11 tasks
auto-submit bot pushed a commit to flutter/packages that referenced this issue Aug 15, 2023
@camsim99
[camerax] Wrap classes to implement resolution configuration for vide…
003a6c0 
…o capture (#4620)

Wraps classes to implement resolution configuration for video capture. No functionality changes.

Part of flutter/flutter#120462.
auto-submit bot pushed a commit to flutter/packages that referenced this issue Sep 8, 2023
@camsim99
[camerax] Implement resolution configuration (#3799)
c6fe5fa 
Adds resolution configuration for all camera use cases. Also makes minor updates to related documentation.

Fixes flutter/flutter#120462.
@danagbemava-nc danagbemava-nc added the r: fixed Issue is closed as already fixed in a newer version label Sep 8, 2023
@camsim99 camsim99 moved this from In progress to Done in Android Camera Re-write Sep 11, 2023
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@camsim99 camsim99

Labels
c: new feature Nothing broken; request for a new capability c: proposal A detailed proposal for a change to Flutter p: camera The camera plugin P2 Important issues not at the top of the work list package flutter/packages repository. See also p: labels. platform-android Android applications specifically r: fixed Issue is closed as already fixed in a newer version team-android Owned by Android platform team triaged-android Triaged by Android platform team
Projects
Android Camera Re-write
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[camerax] Implement resolution configuration camsim99/packages
5 participants
@stuartmorgan @Hixie @camsim99 @danagbemava-nc @iakmds