-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[camerax] Implement flash mode configuration #120715
Comments
@camsim99 I'd like to contribute to this one, but I see there is an ongoing project with this feature. Should we hold off until the rewrite is complete? Or is it in a stable enough place that I can create a PR? |
@FXschwartz I think we should hold off until the plugin is at least a little more stable and the primary use cases have been implemented. I can update this issue when it is at that point! |
@FXschwartz Just FYI, I am working on a PR to implement all of the camera modes except torch mode. It's one I started a while ago because I wanted to land it on a tight timeline, but I didn't end up finishing. After that lands, we'll still need to implement support for torch mode. I am looking to confine work on that to the quarter, but if you want to work on that part, let me know! |
Implements off, auto, and always flash configurations for image capture. Part of flutter/flutter#120715.
Implements the torch flash mode. Also wraps classes necessary for the implementation (a method in `Camera`, `CameraControl`). Fixes flutter/flutter#120715. Fixes flutter/flutter#115846. Part of flutter/flutter#115847.
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of |
Implements the torch flash mode. Also wraps classes necessary for the implementation (a method in `Camera`, `CameraControl`). Fixes flutter/flutter#120715. Fixes flutter/flutter#115846. Part of flutter/flutter#115847.
In the camera plugin API, the method
Future<void> setFlashMode(int cameraId, FlashMode mode)
is used to configure the flash mode for taking pictures and recording video. This method needs to be implemented in the CameraX plugin.For more information on how flash mode configuration works in CameraX, see guide.
The text was updated successfully, but these errors were encountered: