Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[camerax] Implement flash mode configuration #120715

Closed
camsim99 opened this issue Feb 14, 2023 · 4 comments · Fixed by flutter/packages#4903
Closed

[camerax] Implement flash mode configuration #120715

camsim99 opened this issue Feb 14, 2023 · 4 comments · Fixed by flutter/packages#4903
Assignees
@camsim99
Labels
c: new feature Nothing broken; request for a new capability c: proposal A detailed proposal for a change to Flutter customer: castaway p: camera The camera plugin P2 Important issues not at the top of the work list package flutter/packages repository. See also p: labels. platform-android Android applications specifically team-android Owned by Android platform team triaged-android Triaged by Android platform team
Projects
Android Camera Re-write

Comments

@camsim99
Copy link
Contributor

camsim99 commented Feb 14, 2023 •
edited
Loading

In the camera plugin API, the method Future<void> setFlashMode(int cameraId, FlashMode mode) is used to configure the flash mode for taking pictures and recording video. This method needs to be implemented in the CameraX plugin.

For more information on how flash mode configuration works in CameraX, see guide.
@camsim99 camsim99 added c: new feature Nothing broken; request for a new capability platform-android Android applications specifically p: camera The camera plugin c: proposal A detailed proposal for a change to Flutter P2 Important issues not at the top of the work list a: plugins Support for writing, building, and running plugin packages labels Feb 14, 2023
@FXschwartz
Copy link

@camsim99 I'd like to contribute to this one, but I see there is an ongoing project with this feature. Should we hold off until the rewrite is complete? Or is it in a stable enough place that I can create a PR?

@camsim99
Copy link
Contributor Author

camsim99 commented Mar 1, 2023

@FXschwartz I think we should hold off until the plugin is at least a little more stable and the primary use cases have been implemented. I can update this issue when it is at that point!

@stuartmorgan stuartmorgan added package flutter/packages repository. See also p: labels. and removed a: plugins Support for writing, building, and running plugin packages labels Mar 6, 2023
@camsim99 camsim99 moved this from To do to In progress in Android Camera Re-write Apr 22, 2023
@camsim99 camsim99 self-assigned this Apr 22, 2023
@camsim99 camsim99 mentioned this issue Apr 22, 2023
Merged
11 tasks
@flutter-triage-bot flutter-triage-bot bot added multiteam-retriage-candidate team-android Owned by Android platform team triaged-android Triaged by Android platform team labels Jul 8, 2023
@camsim99
Copy link
Contributor Author

@FXschwartz Just FYI, I am working on a PR to implement all of the camera modes except torch mode. It's one I started a while ago because I wanted to land it on a tight timeline, but I didn't end up finishing. After that lands, we'll still need to implement support for torch mode. I am looking to confine work on that to the quarter, but if you want to work on that part, let me know!

auto-submit bot pushed a commit to flutter/packages that referenced this issue Jul 17, 2023
@camsim99
[camerax] Add flash configuration for image capture (#3800)
228c2b1 
Implements off, auto, and always flash configurations for image capture.

Part of flutter/flutter#120715.
@camsim99 camsim99 mentioned this issue Sep 11, 2023
Merged
11 tasks
auto-submit bot pushed a commit to flutter/packages that referenced this issue Oct 10, 2023
@camsim99
[camerax] Implements torch mode (#4903)
bcfa15d 
Implements the torch flash mode. Also wraps classes necessary for the implementation (a method in `Camera`, `CameraControl`).

Fixes flutter/flutter#120715.
Fixes flutter/flutter#115846.
Part of flutter/flutter#115847.
@camsim99 camsim99 moved this from In progress to Done in Android Camera Re-write Oct 10, 2023
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2023
HugoOlthof pushed a commit to moneybird/packages that referenced this issue Dec 13, 2023
@camsim99 @HugoOlthof
[camerax] Implements torch mode (flutter#4903)
d965258 
Implements the torch flash mode. Also wraps classes necessary for the implementation (a method in `Camera`, `CameraControl`).

Fixes flutter/flutter#120715.
Fixes flutter/flutter#115846.
Part of flutter/flutter#115847.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@camsim99 camsim99

Labels
c: new feature Nothing broken; request for a new capability c: proposal A detailed proposal for a change to Flutter customer: castaway p: camera The camera plugin P2 Important issues not at the top of the work list package flutter/packages repository. See also p: labels. platform-android Android applications specifically team-android Owned by Android platform team triaged-android Triaged by Android platform team
Projects
Android Camera Re-write
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[camerax] Implements torch mode camsim99/packages
3 participants
@stuartmorgan @FXschwartz @camsim99