Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrolling is janky in gridView with local images #121525

Closed
delfme opened this issue Feb 27, 2023 · 7 comments · Fixed by flutter/engine#39918
Closed

Scrolling is janky in gridView with local images #121525

delfme opened this issue Feb 27, 2023 · 7 comments · Fixed by flutter/engine#39918
Assignees
@jonahwilliams
Labels
a: images Loading, displaying, rendering images engine flutter/engine repository. See also e: labels. f: scrolling Viewports, list views, slivers, etc. found in release: 3.7 Found to occur in 3.7 found in release: 3.8 Found to occur in 3.8 has reproducible steps The issue has been confirmed reproducible and is ready to work on P2 Important issues not at the top of the work list r: fixed Issue is closed as already fixed in a newer version

Comments

@delfme
Copy link

delfme commented Feb 27, 2023 •
edited
Loading

Scrolling a gridView is janky on ios Impeller.

Tested on latest stable and master 3.8.0-15.0.pre.25, iphone 13 pro, iose 16.1.

Steps to Reproduce

Please run this example here by enabling images from Assets:
https://github.com/delfme/janky-gridview-scrolling

https://github.com/delfme/janky-gridview-scrolling/blob/0098f033403501ba8aee69121d5002fcf36c1686/lib/main.dart#L52-L64

Expected results:
Smooth scrolling.

Actual results:
See video below. Issue is hard to describe. Sometime janks are not noticeable although the feeling is not native-like, other time some jank occurs in a more noticeable way.

videozip_511.MP4

Profiling vid:
We can see initial jank frames. Then at 00:30:40 I started to scrolling a bit faster and noticed more jank frames.

Untitled.mp4

Flutter doctor:

[✓] Flutter (Channel master, 3.8.0-15.0.pre.25, on macOS 12.2 21D49 darwin-arm64, locale en-IT)
[!] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
✗ cmdline-tools component is missing
Run path/to/sdkmanager --install "cmdline-tools;latest"
See https://developer.android.com/studio/command-line for more details.
✗ Android license status unknown.
Run flutter doctor --android-licenses to accept the SDK licenses.
See https://flutter.dev/docs/get-started/install/macos#android-setup for more details.
[✓] Xcode - develop for iOS and macOS (Xcode 13.4.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2021.2)
[✓] Connected device (3 available)
[✓] HTTP Host Availability
@delfme delfme mentioned this issue Feb 27, 2023
Closed
@jonahwilliams
Copy link
Member

This is not related to impeller, as all of the raster and GPU tasks are completed within budget. Instead its probably delays due to impage decompression that we should fix by moving the work to an I/O thread.

@jonahwilliams jonahwilliams changed the title [Impeller] Janky gridView Janky gridView Feb 27, 2023
@delfme
Copy link
Author

delfme commented Feb 27, 2023

Does it mean the same fix might resolve also #121351 ?

Hope you guys can make time for it, smooth scrolling is everything for us

@jonahwilliams jonahwilliams mentioned this issue Feb 27, 2023
Merged
@delfme
Copy link
Author

delfme commented Feb 27, 2023

@jonahwilliams this is so kind of you! 🙏

I just thought that I used imgs from Assets coz it was easier for me to create a demo. But we have janks with remote images as well. Do you want me to update the code?

@jonahwilliams
Copy link
Member

those are unlikely to be fixed via the same change, but you're certainly welcome to file a bug

@delfme
Copy link
Author

delfme commented Feb 27, 2023

I made it #121547
Any idea about what it is causing janks here?

@darshankawar darshankawar added the in triage Presently being triaged by the triage team label Feb 28, 2023
@darshankawar
Copy link
Member

I see a similar janky behavior upon scrolling.

Screenshot 2023-02-28 at 12 25 09 PM

121525.mov

Could be related to : #47380

stable, master flutter doctor -v 
[!] Flutter (Channel stable, 3.7.3, on macOS 12.2.1 21D62 darwin-x64, locale
    en-GB)
    • Flutter version 3.7.3 on channel stable at
      /Users/dhs/documents/fluttersdk/flutter
    ! Warning: `flutter` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/flutter, which is not inside
      your current Flutter SDK checkout at
      /Users/dhs/documents/fluttersdk/flutter. Consider adding
      /Users/dhs/documents/fluttersdk/flutter/bin to the front of your path.
    ! Warning: `dart` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/dart, which is not inside your
      current Flutter SDK checkout at /Users/dhs/documents/fluttersdk/flutter.
      Consider adding /Users/dhs/documents/fluttersdk/flutter/bin to the front
      of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 9944297138 (4 days ago), 2023-02-08 15:46:04 -0800
    • Engine revision 248290d6d5
    • Dart version 2.19.2
    • DevTools version 2.20.1
    • If those were intentional, you can disregard the above warnings; however
      it is recommended to use "git" directly to perform update checks and
      upgrades.

[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (5 available)
    • SM G975F (mobile)       • RZ8M802WY0X • android-arm64   • Android 11 (API 30)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

[!] Flutter (Channel master, 3.8.0-17.0.pre.38, on macOS 12.2.1 21D62
    darwin-x64, locale en-GB)
    • Flutter version 3.8.0-17.0.pre.38 on channel master at
      /Users/dhs/documents/fluttersdk/flutter
    ! Warning: `flutter` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/flutter, which is not inside
      your current Flutter SDK checkout at
      /Users/dhs/documents/fluttersdk/flutter. Consider adding
      /Users/dhs/documents/fluttersdk/flutter/bin to the front of your path.
    ! Warning: `dart` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/dart, which is not inside your
      current Flutter SDK checkout at /Users/dhs/documents/fluttersdk/flutter.
      Consider adding /Users/dhs/documents/fluttersdk/flutter/bin to the front
      of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 1d17caed66 (38 minutes ago), 2023-02-27 23:11:38 -0500
    • Engine revision 002b3d7a24
    • Dart version 3.0.0 (build 3.0.0-277.0.dev)
    • DevTools version 2.22.1
    • If those were intentional, you can disregard the above warnings; however
      it is recommended to use "git" directly to perform update checks and
      upgrades.

[✓] Xcode - develop for iOS and macOS (Xcode 13.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 13C100
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] IntelliJ IDEA Ultimate Edition (version 2021.3.2)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin version 65.1.4
    • Dart plugin version 213.7228

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.29.0

[✓] Connected device (3 available)
    • Darshan's iphone (mobile) • 21150b119064aecc249dfcfe05e259197461ce23 • ios
      • iOS 15.3.1 19D52
    • macOS (desktop)           • macos                                    •
      darwin-x64     • macOS 12.2.1 21D62 darwin-x64
    • Chrome (web)              • chrome                                   •
      web-javascript • Google Chrome 109.0.5414.119

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.
      
[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (5 available)
    • SM G975F (mobile)       • RZ8M802WY0X • android-arm64   • Android 11 (API 30)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

@darshankawar darshankawar added engine flutter/engine repository. See also e: labels. f: scrolling Viewports, list views, slivers, etc. a: images Loading, displaying, rendering images has reproducible steps The issue has been confirmed reproducible and is ready to work on found in release: 3.7 Found to occur in 3.7 found in release: 3.8 Found to occur in 3.8 and removed in triage Presently being triaged by the triage team labels Feb 28, 2023
@darshankawar darshankawar changed the title Janky gridView Scrolling is janky in gridView Feb 28, 2023
@darshankawar darshankawar mentioned this issue Feb 28, 2023
Closed
@delfme delfme changed the title Scrolling is janky in gridView Scrolling is janky in gridView with local images Feb 28, 2023
@chinmaygarde chinmaygarde added the P2 Important issues not at the top of the work list label Mar 6, 2023
@darshankawar darshankawar added the r: fixed Issue is closed as already fixed in a newer version label Mar 8, 2023
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jonahwilliams jonahwilliams

Labels
a: images Loading, displaying, rendering images engine flutter/engine repository. See also e: labels. f: scrolling Viewports, list views, slivers, etc. found in release: 3.7 Found to occur in 3.7 found in release: 3.8 Found to occur in 3.8 has reproducible steps The issue has been confirmed reproducible and is ready to work on P2 Important issues not at the top of the work list r: fixed Issue is closed as already fixed in a newer version
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[engine] move asset mapping copy to background thread jonahwilliams/engine
4 participants
@chinmaygarde @jonahwilliams @delfme @darshankawar