-
Notifications
You must be signed in to change notification settings - Fork 26.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
flutter doctor
should explicitly say when it can't find Android Studio version
#122081
Comments
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
cc @andrewkolos |
This likely applies to the VSCode validator as well: flutter/packages/flutter_tools/lib/src/vscode/vscode_validator.dart Lines 27 to 29 in 0916375
|
… not be detected. (#126395) Fixes #122081. When validating an Android Studio installation, add a warning validation message when we are unable to detect the version. This is because we have logic throughout the tool (JDK/JRE-searching) that is at higher risk of failing when we don't know the version.
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of |
When the tool isn't able to identify what version an Android Studio installation is, that can cause the build to fail because some logic depends on the Android Studio version. For example:
So when someone's running
flutter doctor -v
because things have gone wrong, the fact that the Android Studio version couldn't be identified is potentially a quite important clue for resolving the problem.Currently, though, the
flutter doctor
output just suppresses mention of the version when it doesn't know the answer:The result is a line like
instead of like
This is too subtle; e.g. in #121925 it wasn't noticed in the first few rounds of debugging. It should instead say something like:
or perhaps somewhat louder than that.
The text was updated successfully, but these errors were encountered: