Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[google_maps_flutter_web] add padding to fitBounds #122192

Closed
jxstxn1 opened this issue Mar 8, 2023 · 4 comments
Closed

[google_maps_flutter_web] add padding to fitBounds #122192

jxstxn1 opened this issue Mar 8, 2023 · 4 comments
Labels
c: proposal A detailed proposal for a change to Flutter p: maps Google Maps plugin P2 Important issues not at the top of the work list package flutter/packages repository. See also p: labels. platform-web Web applications specifically r: fixed Issue is closed as already fixed in a newer version

Comments

@jxstxn1
Copy link

jxstxn1 commented Mar 8, 2023

I discovered that the case newLatLngBounds which is under the hood using fitBounds has an comment that package:google_maps: ^4.0.0 is required to implement it.

package:google_maps is currently at 6.2.0 so it should be possible to implement the padding for fitBounds

Here is the comment in the code which I discovered:
https://github.com/flutter/packages/blob/9bfef9513cae3e84ddf3abc0b9c7f2cc99e8d2f4/[…]oogle_maps_flutter/google_maps_flutter_web/lib/src/convert.dart
@jxstxn1
Copy link
Author

jxstxn1 commented Mar 8, 2023

I already implemented it on my fork. I can open it as Pull Request if wanted

@huycozy huycozy added in triage Presently being triaged by the triage team p: maps Google Maps plugin platform-web Web applications specifically package flutter/packages repository. See also p: labels. c: proposal A detailed proposal for a change to Flutter and removed in triage Presently being triaged by the triage team labels Mar 9, 2023
@yjbanov yjbanov added the P2 Important issues not at the top of the work list label Mar 9, 2023
@yjbanov
Copy link
Contributor

yjbanov commented Mar 9, 2023

@jxstxn1 Sure! PRs are welcome. Thank you for working on a fix.

@jxstxn1 jxstxn1 mentioned this issue Mar 13, 2023
Merged
11 tasks
@jxstxn1
Copy link
Author

jxstxn1 commented Mar 28, 2023

@yjbanov Could you review my Pull Request or should I write ditman?

auto-submit bot pushed a commit to flutter/packages that referenced this issue Jun 30, 2023
@jxstxn1
[google_maps_flutter_web] Add padding to newLatLngBounds implementati…
53ed5a0 
…on (#3452)

## Description
This PR is implementing the `padding` argument to `fitBounds` which is called by `newLatLngBounds`.

## Related Issues
[flutter/flutter#122192](flutter/flutter#122192)
@huycozy huycozy added the r: fixed Issue is closed as already fixed in a newer version label Jul 3, 2023
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
c: proposal A detailed proposal for a change to Flutter p: maps Google Maps plugin P2 Important issues not at the top of the work list package flutter/packages repository. See also p: labels. platform-web Web applications specifically r: fixed Issue is closed as already fixed in a newer version
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@stuartmorgan @yjbanov @jxstxn1 @huycozy