Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[image_picker] Restructure Android ImagePickerDelegate codepaths #122808

Open
stuartmorgan opened this issue Mar 16, 2023 · 0 comments
Open

[image_picker] Restructure Android ImagePickerDelegate codepaths #122808

stuartmorgan opened this issue Mar 16, 2023 · 0 comments
Labels
p: image_picker The Image Picker plugin. P3 Issues that are less important to the Flutter project package flutter/packages repository. See also p: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels. team-ecosystem Owned by Ecosystem team triaged-ecosystem Triaged by Ecosystem team

Comments

@stuartmorgan
Copy link
Contributor

Originally the Android implementation had different Dart->Java entry points and different return types for picking one image vs picking multiple images. In flutter/packages#3476 I changed it so that the cross-language call is unified, and there's just a parameter for whether multi-selection should be allowed. The different intent codepaths, success helper methods, etc. are legacy at this point, and could likely be simplified to a single codepath with just the intent parameter being different.

@stuartmorgan stuartmorgan added team Infra upgrades, team productivity, code health, technical debt. See also team: labels. p: image_picker The Image Picker plugin. package flutter/packages repository. See also p: labels. P3 Issues that are less important to the Flutter project labels Mar 16, 2023
@flutter-triage-bot flutter-triage-bot bot added team-ecosystem Owned by Ecosystem team triaged-ecosystem Triaged by Ecosystem team labels Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p: image_picker The Image Picker plugin. P3 Issues that are less important to the Flutter project package flutter/packages repository. See also p: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels. team-ecosystem Owned by Ecosystem team triaged-ecosystem Triaged by Ecosystem team
Projects
None yet
Development

No branches or pull requests

1 participant