Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[image_picker] Migrate Android to Pigeon #3476

Merged
merged 6 commits into from
Mar 16, 2023
Merged

[image_picker] Migrate Android to Pigeon #3476

merged 6 commits into from
Mar 16, 2023

Conversation

stuartmorgan
Copy link
Contributor

@stuartmorgan stuartmorgan commented Mar 16, 2023 •
edited

Migrates image_picker_android to use Pigeon instead of using method channels directly.

I made a few changes to the structure of the interface as part of the switch to Pigeon, which normally I would have done separately in a follow-up, but changing them as part of this PR simplified the transition:

  • Instead of separate methods for single vs multiple selection, there is only multi-selection, with a bool to limit to a single item. This made the callback always have the same type, which eased the migration of PendingCallState's untyped MethodChannel.Result to the typed Messages.Result<List<String>> (instead of needing two different pending result callbacks).
    • I deliberately didn't do any extensive refactoring of the different single-selection vs multi-selection codepaths within the delegate class to go with this, to minimize changes in an already large PR. We may want to simplify that code later.
  • The legacy single-path accessor for lost/cached item retrieval is now entirely on the Dart side, to minimize complexity in the reworked cache/delegate boundary.

There is also some minor incidental cleanup in this PR, as the warning list in Android Studio (which is different than the set of warnings that we check for with the two other warning sweeps that we do in CI because apparently it comes from an AS plugin rather than the other sources 馃槖) was pretty noisy while I was finding my own mistakes, so I fixed some when they were trivial to do.

Fixes flutter/flutter#117909

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@tarrinneal
Copy link
Contributor

I deliberately didn't do any extensive refactoring of the different single-selection vs multi-selection codepaths within the delegate class to go with this, to minimize changes in an already large PR. We may want to simplify that code later.

Can you file an issue for this so I can keep that on my radar?

@stuartmorgan stuartmorgan mentioned this pull request Mar 16, 2023
Open
@stuartmorgan
Copy link
Contributor Author

Filed flutter/flutter#122808

@stuartmorgan stuartmorgan mentioned this pull request Mar 16, 2023
Merged
11 tasks
tarrinneal
tarrinneal approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@tarrinneal tarrinneal left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like good changes. It's a lot of code, but it all seems solid to me!

@stuartmorgan stuartmorgan added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 16, 2023
@auto-submit auto-submit bot merged commit 84afba7 into flutter:main Mar 16, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 17, 2023
@engine-flutter-autoroll
84afba7 [image_picker] Migrate Android to Pigeon (flutter/packages#3476)
b841df8
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 17, 2023
@engine-flutter-autoroll
84afba7 [image_picker] Migrate Android to Pigeon (flutter/packages#3476)
81bc213
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 20, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 20, 2023
@engine-flutter-autoroll
84afba7 [image_picker] Migrate Android to Pigeon (flutter/packages#3476)
a257868
tarrinneal pushed a commit to flutter/flutter that referenced this pull request Mar 20, 2023
@engine-flutter-autoroll
Roll Packages from 44ddf2c to bbf86a7 (19 revisions) (#123015)
95256c0 
* 7636eb7 [go_router_builder] Support default value for `Set`, `List` and `Iterable` route parameters (flutter/packages#3391)

* 26c95da [image_picker] Move HashSet construction within if-statement (flutter/packages#3448)

* f5687b2 [image_picker] fix typos in comments (flutter/packages#3413)

* 84afba7 [image_picker] Migrate Android to Pigeon (flutter/packages#3476)

* 42927fc [image_picker]: Bump androidx.exifinterface:exifinterface from 1.3.3 to 1.3.6 in /packages/image_picker/image_picker_android/android (flutter/packages#3238)

* 9a44bdf Require Dart SDK 2.14, because of using APIs. (flutter/packages#3468)

* 12609a2 [ci] Clean up iOS simulators (flutter/packages#3458)

* 9b136a9 [ci/tool] Add external dependency validation (flutter/packages#3466)

* 11aab47 Manual roll Flutter from fb7e828 to 67e5f66 (8 revisions) (flutter/packages#3482)

* 784291b Update goldens (flutter/packages#3442)

* 43a42d1 [webview_flutter_android] Updates Dart and Java InstanceManagers (flutter/packages#3282)

* d0de136 [camera] Reland android flip/change camera while recording (flutter/packages#3460)

* 74fd094 [image_picker_android] Adjust file extension in FileUtils when it does not match its mime type (flutter/packages#3409)

* d2f1d2d [flutter_adaptive_scaffold] : 馃悰 [FIX] : Issue: 121135. (flutter/packages#3253)

* 3d078b5 Roll Flutter from 67e5f66 to 53dfd23 (39 revisions) (flutter/packages#3484)

* 3b3a09d [url_launcher] Convert iOS to Pigeon (flutter/packages#3481)

* 80cd50a Roll Flutter from 53dfd23 to 6bd2b3c (17 revisions) (flutter/packages#3486)

* 998bb29 [webview_flutter] Updates the README with the migration of `WebView.initialCookies` and Hybrid Composition on (flutter/packages#3470)

* bbf86a7 Roll Flutter from 6bd2b3c to 3e4e092 (7 revisions) (flutter/packages#3490)
@reidbaker reidbaker mentioned this pull request Mar 20, 2023
Merged
10 tasks
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
@stuartmorgan @nploi
[image_picker] Migrate Android to Pigeon (flutter#3476)
5544330 
[image_picker] Migrate Android to Pigeon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarrinneal tarrinneal tarrinneal approved these changes

@gmackall gmackall Awaiting requested review from gmackall gmackall is a code owner

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: image_picker platform-android
Projects
None yet
Milestone
No milestone
2 participants
@stuartmorgan @tarrinneal