Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[go_router][url_launcher] migrate deprecated RouteInformation.location usage #124045

Closed
chunhtai opened this issue Apr 3, 2023 · 2 comments · Fixed by flutter/packages#6127
Closed

[go_router][url_launcher] migrate deprecated RouteInformation.location usage #124045

chunhtai opened this issue Apr 3, 2023 · 2 comments · Fixed by flutter/packages#6127
Assignees
@stuartmorgan
Labels
c: tech-debt Technical debt, code quality, testing, etc. p: deprecated api Use of a deprecated Dart API in flutter/packages that needs to be updated p: go_router The go_router package p: url_launcher Plugin to launch external applications P2 Important issues not at the top of the work list package flutter/packages repository. See also p: labels. team-go_router Owned by Go Router team triaged-go_router Triaged by Go Router team

Comments

@chunhtai
Copy link
Contributor

chunhtai commented Apr 3, 2023

As part of the work of #100624. The RouteInformation.location and other related API is deprecated.
Migration guide https://docs.flutter.dev/release/breaking-changes/route-information-uri

The affected package go_route and url_launcher currently use ignore to get around the deprecation. We should migrate them to new API once the flutter version is bumped
@danagbemava-nc danagbemava-nc added in triage Presently being triaged by the triage team p: url_launcher Plugin to launch external applications package flutter/packages repository. See also p: labels. c: proposal A detailed proposal for a change to Flutter p: go_router The go_router package and removed in triage Presently being triaged by the triage team labels Apr 4, 2023
@stuartmorgan stuartmorgan added the P2 Important issues not at the top of the work list label Apr 4, 2023
@flutter-triage-bot flutter-triage-bot bot added multiteam-retriage-candidate team-go_router Owned by Go Router team triaged-go_router Triaged by Go Router team labels Jul 8, 2023
@chunhtai chunhtai mentioned this issue Dec 27, 2023
Merged
11 tasks
@ChopinDavid
Copy link

This has been migrated in go_router on this PR's branch.

@stuartmorgan stuartmorgan added c: tech-debt Technical debt, code quality, testing, etc. p: deprecated api Use of a deprecated Dart API in flutter/packages that needs to be updated and removed c: proposal A detailed proposal for a change to Flutter labels Feb 13, 2024
stuartmorgan added a commit to stuartmorgan/packages that referenced this issue Feb 14, 2024
@stuartmorgan
[url_launcher] Replace deprecated RouteInformation APIs
aa41fd2 
Update for
https://docs.flutter.dev/release/breaking-changes/route-information-uri
and makes 3.13 the minimum supported version accordingly.

Fixes flutter/flutter#124045
@stuartmorgan stuartmorgan mentioned this issue Feb 14, 2024
Merged
11 tasks
@stuartmorgan stuartmorgan self-assigned this Feb 14, 2024
auto-submit bot pushed a commit to flutter/packages that referenced this issue Feb 15, 2024
@stuartmorgan
[url_launcher] Replace deprecated RouteInformation APIs (#6127)
ef349be 
Update for
https://docs.flutter.dev/release/breaking-changes/route-information-uri and makes 3.13 the minimum supported version accordingly.

Fixes flutter/flutter#124045
@github-actions GitHub Actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
arc-yong pushed a commit to Arctuition/packages-arc that referenced this issue Jun 14, 2024
@stuartmorgan @arc-yong
[url_launcher] Replace deprecated RouteInformation APIs (flutter#6127)
e2b2a76 
Update for
https://docs.flutter.dev/release/breaking-changes/route-information-uri and makes 3.13 the minimum supported version accordingly.

Fixes flutter/flutter#124045
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@stuartmorgan stuartmorgan

Labels
c: tech-debt Technical debt, code quality, testing, etc. p: deprecated api Use of a deprecated Dart API in flutter/packages that needs to be updated p: go_router The go_router package p: url_launcher Plugin to launch external applications P2 Important issues not at the top of the work list package flutter/packages repository. See also p: labels. team-go_router Owned by Go Router team triaged-go_router Triaged by Go Router team
Projects
No open projects
GoRouter
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[url_launcher] Replace deprecated RouteInformation APIs stuartmorgan/packages
4 participants
@stuartmorgan @ChopinDavid @chunhtai @danagbemava-nc