Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hint text on TextField isn't positioned correctly when textScaleFactor is large #12485

Closed
gspencergoog opened this issue Oct 10, 2017 · 1 comment · Fixed by #12595
Closed

Hint text on TextField isn't positioned correctly when textScaleFactor is large #12485

gspencergoog opened this issue Oct 10, 2017 · 1 comment · Fixed by #12595
Assignees
@gspencergoog
Labels
a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels.
Milestone
3: Current Milestone

Comments

@gspencergoog
Copy link
Contributor

When the textScaleFactor is large, the hint text appears in the middle of the field underline decoration, so either the underline location is not calculated correctly, or the hint position isn't.

screenshot_20171010-104453
@gspencergoog gspencergoog added the a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) label Oct 10, 2017
@gspencergoog gspencergoog self-assigned this Oct 10, 2017
@Hixie Hixie added framework flutter/packages/flutter repository. See also f: labels. a: text input Entering text in a text field or keyboard related problems labels Oct 10, 2017
@Hixie Hixie added this to the 3: Current Milestone milestone Oct 10, 2017
@gspencergoog gspencergoog mentioned this issue Oct 18, 2017
Merged
gspencergoog added a commit that referenced this issue Oct 19, 2017
@gspencergoog
Fixes InputDecorator to work with textScaleFactor, fixes Material Des…
67cf791 
…ign differences. (#12595)

Fixes InputDecorator to work with textScaleFactor, fixes Material Design differences.

There were a number of differences with the Material Design spec, including
several different padding values and underline thickness.  This corrects
that so that the decorator is in line with the Material Design spec now.

Also, the decorator properly handles changes to the textScaleFactor, where
before it would not re-layout when needed, painting the cursor and
underline incorrectly.

The decorator also now properly animates helper, error, and hint text when
the textScaleFactor or input decoration properties change.

Helper text is now properly displayed in dense mode, as the spec shows.
Before this change, it was never displayed in dense mode.

Fixes #12485
@github-actions
Copy link

github-actions bot commented Sep 4, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gspencergoog gspencergoog

Labels
a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
3: Current Milestone
2 participants
@Hixie @gspencergoog