Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Engine android CI should verify VisibleForTests field are not used #124890

Open
CaseyHillers opened this issue Apr 14, 2023 · 2 comments
Open

Engine android CI should verify VisibleForTests field are not used #124890

CaseyHillers opened this issue Apr 14, 2023 · 2 comments
Labels
engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list platform-android Android applications specifically team Infra upgrades, team productivity, code health, technical debt. See also team: labels. team-android Owned by Android platform team triaged-android Triaged by Android platform team

Comments

@CaseyHillers
Copy link
Contributor

We had to send a revert in flutter/engine#41211 as this failed analysis checks on Google Testing, but not the LUCI checks.

shell/platform/android/io/flutter/plugin/editing/TextInputPlugin.java:239: Error: This method should only be accessed from tests or within private scope [VisibleForTests]
      imeSyncCallback.remove();

My expectation is analysis checks like this should be caught in presubmit.
@CaseyHillers CaseyHillers added team Infra upgrades, team productivity, code health, technical debt. See also team: labels. platform-android Android applications specifically engine flutter/engine repository. See also e: labels. labels Apr 14, 2023
@CaseyHillers
Copy link
Contributor Author

\cc @reidbaker

@CaseyHillers CaseyHillers mentioned this issue Apr 14, 2023
Merged
@ksballetba
Copy link
Contributor

\cc @reidbaker

@reidbaker

It looks like I didn't change this code, this lint problem exists before my code change.
And I found same lint issue in TextInputPlugin.

image

@reidbaker reidbaker added the P2 Important issues not at the top of the work list label Apr 17, 2023
@ksballetba ksballetba mentioned this issue Apr 26, 2023
Merged
8 tasks
auto-submit bot pushed a commit to flutter/engine that referenced this issue May 5, 2023
@ksballetba
Close connection on keyboard close (#41500)
c97a0de 
Fix:
- flutter/flutter#123523
- flutter/flutter#124890

### Before this patch:

https://user-images.githubusercontent.com/30322203/228413196-29c57bb0-3220-495b-9e73-f58777de440f.mp4

### After this patch:

https://user-images.githubusercontent.com/30322203/228413249-fc06f49d-6579-4476-9788-90f12a53b8c3.mp4
@flutter-triage-bot flutter-triage-bot bot added multiteam-retriage-candidate team-android Owned by Android platform team triaged-android Triaged by Android platform team labels Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list platform-android Android applications specifically team Infra upgrades, team productivity, code health, technical debt. See also team: labels. team-android Owned by Android platform team triaged-android Triaged by Android platform team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Hixie @reidbaker @CaseyHillers @ksballetba