Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[camerax] Implement locking/unlocking capture orientation #125915

Closed
2 tasks done
camsim99 opened this issue May 2, 2023 · 1 comment · Fixed by flutter/packages#5285
Closed
2 tasks done

[camerax] Implement locking/unlocking capture orientation #125915

camsim99 opened this issue May 2, 2023 · 1 comment · Fixed by flutter/packages#5285
Assignees
@camsim99
Labels
c: new feature Nothing broken; request for a new capability c: proposal A detailed proposal for a change to Flutter p: camera The camera plugin P2 Important issues not at the top of the work list package flutter/packages repository. See also p: labels. platform-android Android applications specifically team-android Owned by Android platform team triaged-android Triaged by Android platform team
Projects
Android Camera Re-write

Comments

@camsim99
Copy link
Contributor

camsim99 commented May 2, 2023 •
edited

In the camera plugin, you can lock/unlock the capture orientation of capturing images & video. These must be implemented in the CameraX plugin, as well:

  • lockCaptureOrientation()
  • unlockCaptureOrientation()
@camsim99 camsim99 added c: new feature Nothing broken; request for a new capability platform-android Android applications specifically p: camera The camera plugin package flutter/packages repository. See also p: labels. c: proposal A detailed proposal for a change to Flutter P2 Important issues not at the top of the work list labels May 2, 2023
@flutter-triage-bot flutter-triage-bot bot added multiteam-retriage-candidate team-android Owned by Android platform team triaged-android Triaged by Android platform team labels Jul 8, 2023
@camsim99 camsim99 moved this from To do to In progress in Android Camera Re-write Oct 25, 2023
@camsim99 camsim99 self-assigned this Oct 25, 2023
@camsim99 camsim99 mentioned this issue Oct 31, 2023
Merged
11 tasks
@huycozy huycozy mentioned this issue Nov 21, 2023
Closed
2 tasks
auto-submit bot pushed a commit to flutter/packages that referenced this issue Jan 2, 2024
@camsim99
[camerax] Implement lockCaptureOrientation & `unlockCaptureOrientat…
bbb4134 
…ion` (#5285)

Implements `lockCaptureOrientation` & `unlockCaptureOrientation` for all camera `UseCase`s. 

Also fixes small bug concerning not initially setting the target rotation of the `UseCase`s to the requested sensor orientation when `createCamera` is called.

Fixes flutter/flutter#125915.
@camsim99 camsim99 moved this from In progress to Done in Android Camera Re-write Jan 2, 2024
@github-actions GitHub Actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@camsim99 camsim99

Labels
c: new feature Nothing broken; request for a new capability c: proposal A detailed proposal for a change to Flutter p: camera The camera plugin P2 Important issues not at the top of the work list package flutter/packages repository. See also p: labels. platform-android Android applications specifically team-android Owned by Android platform team triaged-android Triaged by Android platform team
Projects
Android Camera Re-write
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[camerax] Implement lockCaptureOrientation & unlockCaptureOrientation camsim99/packages
1 participant
@camsim99