Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate cocoon label code to github workflows #126002

Closed
5 tasks done
CaseyHillers opened this issue May 3, 2023 · 3 comments · Fixed by #126012 or flutter/cocoon#2687
Closed
5 tasks done

Migrate cocoon label code to github workflows #126002

CaseyHillers opened this issue May 3, 2023 · 3 comments · Fixed by #126012 or flutter/cocoon#2687
Assignees
Labels
team Infra upgrades, team productivity, code health, technical debt. See also team: labels. team-infra Owned by Infrastructure team

Comments

@CaseyHillers
Copy link
Contributor

CaseyHillers commented May 3, 2023

There's code like https://cs.opensource.google/flutter/cocoon/+/main:app_dart/lib/src/request_handlers/github/webhook_subscription.dart;l=352 that can be moved into the repo under test.

This should make it easier to find, and quicker to deploy.

@CaseyHillers CaseyHillers added team Infra upgrades, team productivity, code health, technical debt. See also team: labels. team-infra Owned by Infrastructure team labels May 3, 2023
@CaseyHillers CaseyHillers self-assigned this May 3, 2023
@CaseyHillers
Copy link
Contributor Author

\cc @itsjustkevin as FYI. This is follow up from some of our discussions about moving Cocoon code into GitHub actions

@CaseyHillers CaseyHillers linked a pull request May 3, 2023 that will close this issue
8 tasks
auto-submit bot pushed a commit that referenced this issue May 9, 2023
@CaseyHillers CaseyHillers reopened this May 9, 2023
auto-submit bot pushed a commit that referenced this issue May 24, 2023
auto-submit bot pushed a commit that referenced this issue May 26, 2023
See last commit for the addition. This passes in yaml lint

#126002
auto-submit bot pushed a commit to flutter/engine that referenced this issue Jun 5, 2023
@CaseyHillers
Copy link
Contributor Author

I sent an email PSA to all the contributors directly notifying them of this change.

auto-submit bot pushed a commit to flutter/cocoon that referenced this issue Jun 6, 2023
auto-submit bot pushed a commit to flutter/engine that referenced this issue Jun 6, 2023
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team Infra upgrades, team productivity, code health, technical debt. See also team: labels. team-infra Owned by Infrastructure team
Projects
None yet
1 participant