Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CP] Fix macOS apps being rejected from app store #127350

Closed
christopherfujino opened this issue May 22, 2023 · 5 comments
Closed

[CP] Fix macOS apps being rejected from app store #127350

christopherfujino opened this issue May 22, 2023 · 5 comments
Assignees
Labels
cp: approved Approved cherry-pick request cp: merge-to-beta Cherry-picks that should be merged to beta cp: merged Cherry-pick has been merged to the release branch. cp: review Cherry-picks in the review queue

Comments

@christopherfujino
Copy link
Member

issue_link

#126705

Commit Hash

7e1a0d4

Target

beta

pr_link

#127349

Impacted Users

Developers of macOS apps who want to publish

Impact Description

Although the flutter macOS app will work locally, when submitting it to the app store the dev will be rejected saying the framework is invalid.

Workaround

Manually deleting the entitlements.txt and without_entitlements.txt files from their build outputs.

Risk

low

Test Coverage

yes

Validation Steps

No response

@godofredoc
Copy link
Contributor

CP: LGTM

@XilaiZhang XilaiZhang added cp: approved Approved cherry-pick request cp: merge-to-beta Cherry-picks that should be merged to beta labels May 22, 2023
auto-submit bot pushed a commit that referenced this issue May 22, 2023
…a cp (#127349)

Cherrypick of #126875

CP request at #127350

Fixes #126705 for the beta release
@borjandev
Copy link

@godofredoc @christopherfujino did you guys verify that the rejection issue has been solved? I tried the TOT on master branch, which is c313083 at the moment, and still the same rejection happens. (unless I am missing some extra step?)

@crossle
Copy link

crossle commented May 23, 2023

@godofredoc @christopherfujino did you guys verify that the rejection issue has been solved? I tried the TOT on master branch, which is c313083 at the moment, and still the same rejection happens. (unless I am missing some extra step?)

Yes, still rejection...

@godofredoc
Copy link
Contributor

Let's keep the conversation in the bug to simplify tracking.

@itsjustkevin itsjustkevin added the cp: merged Cherry-pick has been merged to the release branch. label May 23, 2023
@github-actions
Copy link

github-actions bot commented Jun 7, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cp: approved Approved cherry-pick request cp: merge-to-beta Cherry-picks that should be merged to beta cp: merged Cherry-pick has been merged to the release branch. cp: review Cherry-picks in the review queue
Projects
None yet
Development

No branches or pull requests

7 participants