Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macOS: FlutterViewController does not get released #127572

Closed
knopp opened this issue May 25, 2023 · 1 comment · Fixed by flutter/engine#42317
Closed

macOS: FlutterViewController does not get released #127572

knopp opened this issue May 25, 2023 · 1 comment · Fixed by flutter/engine#42317
Labels
engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list perf: memory Performance issues related to memory platform-mac Building on or for macOS specifically

Comments

@knopp
Copy link
Member

knopp commented May 25, 2023

Added in flutter/engine#40706 FlutterViewWrapper keeps strong reference to FlutterViewController, which holds strong reference to the wrapper.

The reference in FlutterViewWrapper should be weak.
@knopp knopp added engine flutter/engine repository. See also e: labels. platform-mac Building on or for macOS specifically labels May 25, 2023
@knopp knopp changed the title FlutterViewController does not get released on macOS macOS: FlutterViewController does not get released May 25, 2023
@knopp knopp mentioned this issue May 25, 2023
Merged
8 tasks
auto-submit bot pushed a commit to flutter/engine that referenced this issue May 25, 2023
@knopp
[macOS] Fix FlutterViewController retain cycle (#42317)
6ff02c1 
Fixes flutter/flutter#127572

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
@cbracken cbracken added P2 Important issues not at the top of the work list perf: memory Performance issues related to memory labels May 25, 2023
@github-actions
Copy link

github-actions bot commented Jun 8, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list perf: memory Performance issues related to memory platform-mac Building on or for macOS specifically
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[macOS] Fix FlutterViewController retain cycle knopp/engine
2 participants
@knopp @cbracken