Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Impeller] Implement framebuffer fetch via subpass in Vulkan. #128911

Closed
chinmaygarde opened this issue Jun 14, 2023 · 2 comments
Closed

[Impeller] Implement framebuffer fetch via subpass in Vulkan. #128911

chinmaygarde opened this issue Jun 14, 2023 · 2 comments
Assignees
@chinmaygarde
Labels
e: impeller Impeller rendering backend issues and features requests engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list team-engine Owned by Engine team triaged-engine Triaged by Engine team
Milestone
Impeller on Android

Comments

@chinmaygarde
Copy link
Member

This is available in the Metal backend for "free". We work around this today in Vulkan by using multiple render passes. But this is extremely slow. For instance, the the pull quotes in the Wondrous app are really pretty bad without this optimization.

We need framebuffer fetch in Vulkan.
@chinmaygarde chinmaygarde added engine flutter/engine repository. See also e: labels. e: impeller Impeller rendering backend issues and features requests P2 Important issues not at the top of the work list labels Jun 14, 2023
@chinmaygarde chinmaygarde added this to the Impeller on Android milestone Jun 27, 2023
@flutter-triage-bot flutter-triage-bot bot added team-engine Owned by Engine team triaged-engine Triaged by Engine team labels Jul 8, 2023
@chinmaygarde chinmaygarde self-assigned this Aug 4, 2023
chinmaygarde added a commit to chinmaygarde/flutter_engine that referenced this issue Sep 12, 2023
@chinmaygarde
[Impeller] Patch the compiler to account for subpass inputs and PSO m…
ff42fb2 
…etadata.

Towards flutter/flutter#128911
Drive by fixes flutter/flutter#123795
@chinmaygarde chinmaygarde mentioned this issue Sep 12, 2023
Merged
@chinmaygarde
Copy link
Member Author

Part of #120223

auto-submit bot pushed a commit to flutter/engine that referenced this issue Sep 12, 2023
@chinmaygarde
[Impeller] Patch the compiler to account for subpass inputs and PSO m…
6f223db 
…etadata. (#45739)

Towards flutter/flutter#128911

Drive by fixes flutter/flutter#123795
@flar flar changed the title [Impeller] Implement framebuffer fetch via subpasss in Vulkan. [Impeller] Implement framebuffer fetch via subpass in Vulkan. Sep 27, 2023
@github-actions GitHub Actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chinmaygarde chinmaygarde

Labels
e: impeller Impeller rendering backend issues and features requests engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list team-engine Owned by Engine team triaged-engine Triaged by Engine team
Projects
No open projects
Impeller
Status: ⚙️ In Progress
Milestone
Impeller on Android
Development

No branches or pull requests
1 participant
@chinmaygarde