Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS should support view Controller based status bar styles. #128969

Closed
3 tasks done
cyanglaz opened this issue Jun 15, 2023 · 1 comment
Closed
3 tasks done

iOS should support view Controller based status bar styles. #128969

cyanglaz opened this issue Jun 15, 2023 · 1 comment
Assignees
@cyanglaz
Labels
engine flutter/engine repository. See also e: labels. framework flutter/packages/flutter repository. See also f: labels. P1 High-priority issues at the top of the work list package flutter/packages repository. See also p: labels. platform-ios iOS applications specifically team-ios Owned by iOS platform team triaged-ios Triaged by iOS platform team

Comments

@cyanglaz
Copy link
Contributor

cyanglaz commented Jun 15, 2023 •
edited

UIApplication based status bar style APIs are deprecated in iOS 9 and iOS 13, see #128730

We should update to use the view controller based status bar.

The tasks includes:

  • Update the engine code to use the view controller status bar APIs for newer iOS versions, keep the UIApplication based code. (done in [ios] view controller based status bar engine#42643)
  • Update the info.plist template so that UIViewControllerBasedStatusBar is true.
  • Update UIViewControllerBasedStatusBar to be true for all the examples apps in packages, framework and engine
    - [ ] ??Add a migration so all the existing Flutter apps will have UIViewControllerBasedStatusBar to be true. (We need to evaluate if we should do this)
@cyanglaz cyanglaz added platform-ios iOS applications specifically framework flutter/packages/flutter repository. See also f: labels. engine flutter/engine repository. See also e: labels. package flutter/packages repository. See also p: labels. P1 High-priority issues at the top of the work list labels Jun 15, 2023
@cyanglaz cyanglaz self-assigned this Jun 15, 2023
This was referenced Jun 15, 2023
Merged
Merged
Merged
auto-submit bot pushed a commit to flutter/packages that referenced this issue Jun 19, 2023
[all] Update UIViewControllerBasedStatusBarAppearance to true (#4225)
6e1918f 
Now that we support UIViewControllerBasedStatusBar by default (after engine roll: flutter/flutter@c716776), we should make this value to be true.

Part of flutter/flutter#128969
fluttermirroringbot pushed a commit that referenced this issue Jun 20, 2023
iOS info.plist template: make UIViewControllerBasedStatusBar to be tr…
fadcaee 
…ue (#128970)

Now that we support UIViewControllerBasedStatusBar by default (after engine roll: c716776), we should make this value to be true.

Part of #128969
@flutter-triage-bot flutter-triage-bot bot added multiteam-retriage-candidate team-ios Owned by iOS platform team triaged-ios Triaged by iOS platform team labels Jul 8, 2023
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cyanglaz cyanglaz

Labels
engine flutter/engine repository. See also e: labels. framework flutter/packages/flutter repository. See also f: labels. P1 High-priority issues at the top of the work list package flutter/packages repository. See also p: labels. platform-ios iOS applications specifically team-ios Owned by iOS platform team triaged-ios Triaged by iOS platform team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cyanglaz