Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows Arm64] Add build-only Arm64 CI to flutter/packages #129813

Open
3 of 4 tasks
Tracked by #62597
loic-sharma opened this issue Jun 30, 2023 · 4 comments
Open
3 of 4 tasks
Tracked by #62597

[Windows Arm64] Add build-only Arm64 CI to flutter/packages #129813

loic-sharma opened this issue Jun 30, 2023 · 4 comments
Labels
a: desktop Running on desktop a: plugins Support for writing, building, and running plugin packages P3 Issues that are less important to the Flutter project platform-windows Building on or for Windows specifically team-windows Owned by the Windows platform team triaged-windows Triaged by the Windows platform team

Comments

@loic-sharma
Copy link
Member

loic-sharma commented Jun 30, 2023 •
edited

Background

Flutter is being updated to support Windows Arm64: https://flutter.dev/go/windows-arm64

Work
@loic-sharma loic-sharma added platform-windows Building on or for Windows specifically a: desktop Running on desktop P3 Issues that are less important to the Flutter project a: plugins Support for writing, building, and running plugin packages labels Jun 30, 2023
@loic-sharma loic-sharma mentioned this issue Jun 30, 2023
Open
17 tasks
@stuartmorgan
Copy link
Contributor

Can you update when the build support actually lands in flutter? Once it does this should be relatively straightforward.

This was referenced Oct 12, 2023
Merged
Closed
Merged
auto-submit bot pushed a commit to flutter/packages that referenced this issue Oct 13, 2023
@loic-sharma
[ci] Add x64 specific Windows platform (#5133)
68eedfd 
This begins to migrate the Windows CI tests to use a new x64 specific Windows platform. For now these duplicate the existing tests in `bringup` mode.

A subsequent pull request (#5141) will complete the migration by removing the old Windows tests and removing the `bringup` from the new x64 specific tests. Here are the resulting changes from both steps of the migration: main...loic-sharma:flutter-packages:windows_x64_ci_finalize

In the future, a new platform will be added for Windows Arm64 tests.

Prepares for flutter/flutter#129813

Subsequent pull requests:
* #5141
* #5142
@loic-sharma loic-sharma mentioned this issue Oct 18, 2023
Merged
11 tasks
auto-submit bot pushed a commit to flutter/packages that referenced this issue Oct 20, 2023
@loic-sharma
[ci] Finalize migration to x64 specific Windows platform (#5174)
be915be 
#5133 began to migrate the Windows CI tests to use a new x64 specific Windows platform. This completes the migration by removing the old Windows tests and removing `bringup` from the new x64 specific tests.

To see the resulting changes from both steps of the migration, refer to: 0bddb16...loic-sharma:flutter-packages:windows_x64_ci_finalize_2#diff-9e73abde9fff445f31e5928e80d2d3f88847e02fd8f76d46f66f147fdc82786d

Prepares for flutter/flutter#129813

Previous stacked pull request: #5133
Next stacked pull request: #5142
auto-submit bot pushed a commit to flutter/packages that referenced this issue Oct 20, 2023
@loic-sharma
[ci] Add build-only Windows Arm64 tests (#5142)
e02d2a5 
Add build-only Windows Arm64 CI tests, mirroring the way we handle multi-arch for macOS.

Completes: flutter/flutter#129813

Previous stacked pull requests:
* #5133
* #5174
@loic-sharma loic-sharma mentioned this issue Oct 20, 2023
Merged
11 tasks
auto-submit bot pushed a commit to flutter/packages that referenced this issue Oct 23, 2023
@loic-sharma
[ci] Remove device_type property from Windows Arm64 properties (#5193)
30b1094 
The Windows Arm64 tests are failing to start as no machines match desired properties. This removes the `device_type: none` property as no Windows Arm64 machines match this ([with `device_type`](https://chromium-swarm.appspot.com/botlist?c=id&c=task&c=os&c=status&d=asc&f=cpu%3Aarm64&f=os%3AWindows&f=pool%3Aluci.flutter.staging&f=device_type%3Anone&s=id), [without `device_type`](https://chromium-swarm.appspot.com/botlist?c=id&c=task&c=os&c=status&d=asc&f=cpu%3Aarm64&f=os%3AWindows&f=pool%3Aluci.flutter.staging&s=id)).

This matches the corresponding framework `.ci.yaml` platform properties, which also omits the `device_type: none` for Windows Arm64: https://github.com/flutter/flutter/blob/997a94fd1f022492b6c955013eeec7e4c4e67c62/.ci.yaml#L192-L209

Part of flutter/flutter#129813
@loic-sharma loic-sharma self-assigned this Oct 24, 2023
@loic-sharma loic-sharma mentioned this issue Oct 24, 2023
Merged
11 tasks
auto-submit bot pushed a commit to flutter/packages that referenced this issue Oct 25, 2023
@loic-sharma
[ci] Disable Windows Arm64 stable CI (#5217)
a927ade 
The Windows Arm64 build-only stable test is currently failing as the necessary build layout migration hasn't landed on stable yet: flutter/flutter@792e26d

This test can be re-added after the next Flutter stable release. This is tracked by flutter/flutter#129813
@loic-sharma loic-sharma mentioned this issue Dec 1, 2023
Merged
11 tasks
auto-submit bot pushed a commit to flutter/packages that referenced this issue Dec 4, 2023
@loic-sharma
[ci] Add Windows Arm64 stable build-only test (#5533)
4e7f160 
Now that the [Windows build directory update](flutter/flutter@792e26d) migration is on the stable channel, add the build-only Windows Arm64 CI stable test.

Part of flutter/flutter#129813
HugoOlthof pushed a commit to moneybird/packages that referenced this issue Dec 13, 2023
@loic-sharma @HugoOlthof
[ci] Add x64 specific Windows platform (flutter#5133)
085a78c 
This begins to migrate the Windows CI tests to use a new x64 specific Windows platform. For now these duplicate the existing tests in `bringup` mode.

A subsequent pull request (flutter#5141) will complete the migration by removing the old Windows tests and removing the `bringup` from the new x64 specific tests. Here are the resulting changes from both steps of the migration: flutter/packages@main...loic-sharma:flutter-packages:windows_x64_ci_finalize

In the future, a new platform will be added for Windows Arm64 tests.

Prepares for flutter/flutter#129813

Subsequent pull requests:
* flutter#5141
* flutter#5142
HugoOlthof pushed a commit to moneybird/packages that referenced this issue Dec 13, 2023
@loic-sharma @HugoOlthof
[ci] Finalize migration to x64 specific Windows platform (flutter#5174)
d37d3f0 
flutter#5133 began to migrate the Windows CI tests to use a new x64 specific Windows platform. This completes the migration by removing the old Windows tests and removing `bringup` from the new x64 specific tests.

To see the resulting changes from both steps of the migration, refer to: flutter/packages@0bddb16...loic-sharma:flutter-packages:windows_x64_ci_finalize_2#diff-9e73abde9fff445f31e5928e80d2d3f88847e02fd8f76d46f66f147fdc82786d

Prepares for flutter/flutter#129813

Previous stacked pull request: flutter#5133
Next stacked pull request: flutter#5142
HugoOlthof pushed a commit to moneybird/packages that referenced this issue Dec 13, 2023
@loic-sharma @HugoOlthof
[ci] Add build-only Windows Arm64 tests (flutter#5142)
59b7ff5 
Add build-only Windows Arm64 CI tests, mirroring the way we handle multi-arch for macOS.

Completes: flutter/flutter#129813

Previous stacked pull requests:
* flutter#5133
* flutter#5174
HugoOlthof pushed a commit to moneybird/packages that referenced this issue Dec 13, 2023
@loic-sharma @HugoOlthof
[ci] Remove device_type property from Windows Arm64 properties (flutt…
a906e29 
…er#5193)

The Windows Arm64 tests are failing to start as no machines match desired properties. This removes the `device_type: none` property as no Windows Arm64 machines match this ([with `device_type`](https://chromium-swarm.appspot.com/botlist?c=id&c=task&c=os&c=status&d=asc&f=cpu%3Aarm64&f=os%3AWindows&f=pool%3Aluci.flutter.staging&f=device_type%3Anone&s=id), [without `device_type`](https://chromium-swarm.appspot.com/botlist?c=id&c=task&c=os&c=status&d=asc&f=cpu%3Aarm64&f=os%3AWindows&f=pool%3Aluci.flutter.staging&s=id)).

This matches the corresponding framework `.ci.yaml` platform properties, which also omits the `device_type: none` for Windows Arm64: https://github.com/flutter/flutter/blob/997a94fd1f022492b6c955013eeec7e4c4e67c62/.ci.yaml#L192-L209

Part of flutter/flutter#129813
HugoOlthof pushed a commit to moneybird/packages that referenced this issue Dec 13, 2023
@loic-sharma @HugoOlthof
[ci] Disable Windows Arm64 stable CI (flutter#5217)
e78f912 
The Windows Arm64 build-only stable test is currently failing as the necessary build layout migration hasn't landed on stable yet: flutter/flutter@792e26d

This test can be re-added after the next Flutter stable release. This is tracked by flutter/flutter#129813
HugoOlthof pushed a commit to moneybird/packages that referenced this issue Dec 13, 2023
@loic-sharma @HugoOlthof
[ci] Add Windows Arm64 stable build-only test (flutter#5533)
908c61d 
Now that the [Windows build directory update](flutter/flutter@792e26d) migration is on the stable channel, add the build-only Windows Arm64 CI stable test.

Part of flutter/flutter#129813
@loic-sharma loic-sharma mentioned this issue Feb 20, 2024
Merged
11 tasks
auto-submit bot pushed a commit to flutter/packages that referenced this issue Feb 21, 2024
@loic-sharma
[ci] Run Windows Arm64 build tests post-submit (#6166)
9c15ec5 
The Flutter try pool does not have any Windows Arm64 machines. Thus, any Windows Arm64 pre-submit tests would fail without `bringup: true` as there's no machines to run them.

This change will allow us to promote the Windows Arm64 build tests out of `bringup`.

See: flutter/flutter#141986
Part of flutter/flutter#129813
@loic-sharma loic-sharma removed their assignment Mar 27, 2024
@stuartmorgan
Copy link
Contributor

Is the current state intentional? The blocking issue was fixed but the bots are still in bringup mode.

@loic-sharma
Copy link
Member Author

@stuartmorgan Yes, these tests should be able to be promoted out of bringup mode. There are no known blockers at this time.

Some context: infra folks expected they wouldn't add Windows Arm64 machines to the try pool due to capacity shortages. As a workaround, I switched these tests to post-submit (flutter/packages#6166) so that they could run on the staging pool instead and could be promoted. I haven't had the chance to follow-up on that, I don't expect I'll be able to given the reprioritization.

@cbracken cbracken added team-windows Owned by the Windows platform team and removed team-desktop labels Jun 6, 2024
@flutter-triage-bot
Copy link

The triaged-desktop label is irrelevant if there is no team-desktop label or fyi-desktop label.

@cbracken cbracken added the triaged-windows Triaged by the Windows platform team label Jun 7, 2024
arc-yong pushed a commit to Arctuition/packages-arc that referenced this issue Jun 14, 2024
@loic-sharma @arc-yong
[ci] Add Windows Arm64 stable build-only test (flutter#5533)
f0295c0 
Now that the [Windows build directory update](flutter/flutter@792e26d) migration is on the stable channel, add the build-only Windows Arm64 CI stable test.

Part of flutter/flutter#129813
arc-yong pushed a commit to Arctuition/packages-arc that referenced this issue Jun 14, 2024
@loic-sharma @arc-yong
[ci] Run Windows Arm64 build tests post-submit (flutter#6166)
b1254c3 
The Flutter try pool does not have any Windows Arm64 machines. Thus, any Windows Arm64 pre-submit tests would fail without `bringup: true` as there's no machines to run them.

This change will allow us to promote the Windows Arm64 build tests out of `bringup`.

See: flutter/flutter#141986
Part of flutter/flutter#129813
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a: desktop Running on desktop a: plugins Support for writing, building, and running plugin packages P3 Issues that are less important to the Flutter project platform-windows Building on or for Windows specifically team-windows Owned by the Windows platform team triaged-windows Triaged by the Windows platform team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stuartmorgan @cbracken @loic-sharma