New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autofill support #13015
Comments
Doesn't the Autofill framework work whenever an input is recognized natively? new TextFormField(
keyboardType: TextInputType.emailAddress
...
) do the trick? |
fwiw, I have the following form: Form(
child: Column(
children: <Widget>[
TextFormField(
keyboardType: TextInputType.emailAddress,
decoration: new InputDecoration(
hintText: "Email",
labelText: "Email"
),
),
TextFormField(
obscureText: true,
decoration: new InputDecoration(
labelText: "Password"
),
)
],
)
), And 1Password doesn't seem to be triggering. |
The Android auto-fill framework wasn't added until SDK 26, so I doubt we support it currently since Flutter's target SDK is still 22 |
We will definitely have to support it. We will just have to call back to nothing on older Androids. |
This comment has been minimized.
This comment has been minimized.
Similarly we should ensure that we support the same for the password field changes in iOS 11 (may already work?) and the upcoming changes in iOS 12. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Ok, so I have confirmation from @dnfield that we should now be unblocked. What's the current status on this ticket? What needs to be done? Can I help? |
https://developer.android.com/guide/topics/text/autofill-optimize#virtual needs to be implemented in the Android TextInputPlugin. |
Well, I am pleased to see that lastpass is at least able to acknowledge the presence of email/password fields and prompts to autofill. Unfortunately that's where the good new stops, because it can't seem to actually perform the autofill action :( |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
+1 |
Any idea when this might be scheduled for? |
This would be great to have. Saves the user from typing over and over again! |
This should be working on the master branch now. Please open new issues for feature requests / bug reports! Known issues:
Upcoming features:
|
I have this issu also on the web version... any idea how to fix? |
as far as I can see, the latest master channel already implements this for flutter web, I can see the autocomplete attributes being set, but apparently the input text fields are generated on the fly, so chrome continues to offer only saving for the password input field, anyone else who can reproduce this? |
@Freundschaft Thanks for the question. We are working on that part, there needs to be changes on the framework, later we will merge the Flutter Web changes. The tracking issue: #55613 |
Chrome has offered to save and autofill my password on a website I built with Flutter Web. I believe I was on the master channel when I compiled it.
Yes, I have the same issue, Chrome only offers to save and fill the password but not the username. |
@Levi-Lesches yes we didn't merge the "save" solution yet. Since some fields handled different by the browsers you can see the save popups for some fields. |
@nturgut Is the "save" solution merged? Is it tracked using this issue or there is some other issue? |
Wondering if anyone else has this autofill problem. On iOS, when I have multiple text fields on a screen with different autofill hints, tapping between the text fields does not update the autofill correctly. Sometimes the autofill just doesn't show up. Sometimes the first autofill item just stays and never switches. Sometimes when I leave the app and come back, all the autofills have change to "Passwords" with the key icon. Might be related to #59374 |
Yep, same here. |
Save solution is merged. Sorry I just saw this cc. |
@jacob-hutchings @stx thanks for reporting this issue! What's your flutter version? From the screenshot it seems it happens on non-password fields right? For those fields I think we reuse the same ios view and I've never had this issue, but it's possible ios autofill caches the content type internally. Could you provide a minimal repro for investigation? |
Thank you for looking at this @LongCatIsLooong ! Here is my Flutter version info: Flutter (Channel stable, 1.20.2, on Mac OS X 10.15.4 19E287, locale en-US) I tested the following code on my physical iPhone 8 and also the iOS simulator iPhone SE (2nd Gen). Autofill straight up never works with the following code for me:
I repeatedly tested this, rebuilding, force quitting and launching, and it never showed. After adding
After testing tens of times I finally got it to update one time, but I'm not sure how I got it to work. The behavior is very inconsistent. Please let me know if there is additional info you need. |
My login form is defined as follows:
On Android, I am never getting any autofill. Is that anything wrong in my code? Issue is closed, so I guess functionality is finished, so what's wrong? I expected autfill like this: https://youtu.be/DvvaxPTBoxQ?t=183 but it never shows. What am I doing wrong? |
Every post I saw about Autofill they wrap the Widget were the TextInputFields in with an AutofillGroup. I does it the same way and it works fine. |
Wrapping with
Have you managed to make it working with other password managers? |
Ref this issue #55613 (comment). |
I tried to wrap |
Hello, it works !!! Wrap the fields with AutoFillGroup and add to each field your autoFillHint is magic in web. The autocomplete with email and password started to work. Thanks |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of |
We should make sure our text fields trigger the autofill support:
https://developer.android.com/guide/topics/text/autofill.html
The text was updated successfully, but these errors were encountered: