Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flake in MessageLoop.CanCreateConcurrentMessageLoop on Windows #130344

Closed
zanderso opened this issue Jul 11, 2023 · 1 comment · Fixed by flutter/engine#43574
Closed

Flake in MessageLoop.CanCreateConcurrentMessageLoop on Windows #130344

zanderso opened this issue Jul 11, 2023 · 1 comment · Fixed by flutter/engine#43574
Labels
c: flake Tests that sometimes, but not always, incorrectly pass platform-windows Building on or for Windows specifically team-engine Owned by Engine team

Comments

@zanderso
Copy link
Member

https://ci.chromium.org/ui/p/flutter/builders/prod/Windows%20windows_unopt/1188/overview

[331/380] MessageLoop.CanCreateConcurrentMessageLoop (2105 ms)
[INFO:logging_unittests.cc(31)] This log exists to verify that static logging from FML works.
[INFO:test_timeout_listener.cc(76)] Test timeout of 120 seconds per test case will be enforced.
Note: Google Test filter = MessageLoop.CanCreateConcurrentMessageLoop
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from MessageLoop
[ RUN      ] MessageLoop.CanCreateConcurrentMessageLoop
Ran on thread: 2872Ran on thread: Ran on thread: 13952
Ran on thread: 11952
Ran on thread: 8380Ran on thread:

8216
Ran on thread: 10092
8288
Ran on thread: 3828
Ran on thread: 11952
Ran on thread: 13952
D:\a\_work\1\s\src\vctools\crt\github\stl\src\mutex.cpp(61): mutex destroyed while busy
[331/380] MessageLoop.CanCreateConcurrentMessageLoop returned/aborted with exit code 3 (2105 ms)
@zanderso zanderso added platform-windows Building on or for Windows specifically c: flake Tests that sometimes, but not always, incorrectly pass team-engine Owned by Engine team labels Jul 11, 2023
jason-simmons added a commit to jason-simmons/flutter_engine that referenced this issue Jul 11, 2023
@jason-simmons
Release the mutex in the CanCreateConcurrentMessageLoop test before w…
7a5da11 
…aking the latch

If the wake happens while thread_ids_mutex is still held, then the test
function may exit and destroy thread_ids_mutex before the pool thread
task releases it.

Fixes flutter/flutter#130344
@jason-simmons jason-simmons mentioned this issue Jul 11, 2023
Merged
auto-submit bot pushed a commit to flutter/engine that referenced this issue Jul 11, 2023
@jason-simmons
Release the mutex in the CanCreateConcurrentMessageLoop test before w…
d00590f 
…aking the latch (#43574)

If the wake happens while thread_ids_mutex is still held, then the test function may exit and destroy thread_ids_mutex before the pool thread task releases it.

Fixes flutter/flutter#130344
kjlubick pushed a commit to kjlubick/engine that referenced this issue Jul 14, 2023
@jason-simmons @kjlubick
Release the mutex in the CanCreateConcurrentMessageLoop test before w…
0f0e935 
…aking the latch (flutter#43574)

If the wake happens while thread_ids_mutex is still held, then the test function may exit and destroy thread_ids_mutex before the pool thread task releases it.

Fixes flutter/flutter#130344
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
c: flake Tests that sometimes, but not always, incorrectly pass platform-windows Building on or for Windows specifically team-engine Owned by Engine team
Projects
None yet
Milestone
No milestone
1 participant
@zanderso