-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hybrid_android_views_integration_test depends on NOP rendering calls for correctness #130738
Comments
This issue is the root cause behind this revert of the engine's NOP culling mechanism: flutter/engine#43721 |
johnmccutchan
pushed a commit
that referenced
this issue
Jul 18, 2023
Fixes: #130738 A widget was added to explicitly and intentionally overlap the PlatformView so that the rendering tree of Views would always have an underlay and an overlay to match the test expectations.
LouiseHsu
pushed a commit
to LouiseHsu/flutter
that referenced
this issue
Jul 31, 2023
…er#130751) Fixes: flutter#130738 A widget was added to explicitly and intentionally overlap the PlatformView so that the rendering tree of Views would always have an underlay and an overlay to match the test expectations.
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
This test is blocking an engine PR that ignores rendering calls that don't render anything. The test expects a second
FlutterImageView
which only contains non-rendering operations. If we stop recording those operations then the second FlutterImageView will not be generated and this is treated as a bug by the test.One way to demonstrate the failure without the changes to the engine is to remove the offending calls from the platform and try to run the test - it will fail in the absence of these non-rendering calls. (Note that the indicated diffs are not necessarily an optimal suggested patch for the Framework, but they just serve to eliminate the cases of non-rendering calls which are encountered during this one test and demonstrate its change in expectations.)
There are 3 possible solutions here:
FlutterImageView
to be needed as per the current test expectations. (Does the test want the second View to be present in order to test its conditions properly?)Framework patch to eliminate non-rendering calls
The text was updated successfully, but these errors were encountered: