Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP] Space character should be optional when tree shaking fonts on 3.14 #132978

Closed
christopherfujino opened this issue Aug 21, 2023 · 1 comment
Closed

[CP] Space character should be optional when tree shaking fonts on 3.14 #132978

christopherfujino opened this issue Aug 21, 2023 · 1 comment
Assignees
@godofredoc
Labels
cp: approved Approved cherry-pick request cp: merge-to-beta Cherry-picks that should be merged to beta cp: merged Cherry-pick has been merged to the release branch. cp: review Cherry-picks in the review queue

Comments

@christopherfujino
Copy link
Member

Issue Link

#132711

Commit Hash

376993f

Target

beta 3.14

PR Link

engine: flutter/engine#44908
framework: #132977

Changelog Description

Fixes an issue with tree shaking fonts that do not contain a space glyph.

Impacted Users

Flutter Web apps that have custom fonts that do not contain a space glyph

Impact Description

The flutter tool fails out with an error when attempting to compile an app that uses a custom icon font that does not contain a space.

Workaround

The user can pass --no-tree-shake-icons to prevent icon tree shaking, which will allow the flutter tool to complete the build process. However, it skips icon tree shaking, which bloats the payload size of their font files.

Risk

low

Test Coverage

yes

Validation Steps

New integration tests have been added that ensure that the font-subset tool can handle optional characters. Subsequent testing will happen with the framework change, which will follow.
@christopherfujino christopherfujino added the cp: review Cherry-picks in the review queue label Aug 21, 2023
@christopherfujino christopherfujino mentioned this issue Aug 21, 2023
Merged
@zanderso zanderso added the cp: approved Approved cherry-pick request label Aug 21, 2023
@itsjustkevin itsjustkevin added the cp: merge-to-beta Cherry-picks that should be merged to beta label Aug 22, 2023
@itsjustkevin itsjustkevin reopened this Aug 24, 2023
auto-submit bot pushed a commit to flutter/engine that referenced this issue Aug 24, 2023
@christopherfujino
[CP] fix icon tree-shaking on web for fonts with no space char v3.14 (#…
5aad24e 
…44908)

CP of #44864
CP request flutter/flutter#132978
@godofredoc godofredoc added the cp: merged Cherry-pick has been merged to the release branch. label Aug 31, 2023
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@godofredoc godofredoc

Labels
cp: approved Approved cherry-pick request cp: merge-to-beta Cherry-picks that should be merged to beta cp: merged Cherry-pick has been merged to the release branch. cp: review Cherry-picks in the review queue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@CaseyHillers @zanderso @christopherfujino @itsjustkevin @godofredoc