Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update web platform dependencies to new target names #133606

Closed
nshahan opened this issue Aug 29, 2023 · 1 comment · Fixed by flutter/engine#45404
Closed

Update web platform dependencies to new target names #133606

nshahan opened this issue Aug 29, 2023 · 1 comment · Fixed by flutter/engine#45404
Assignees
@nshahan
Labels
dependency: dart Dart team may need to help us engine flutter/engine repository. See also e: labels. team-web Owned by Web platform team

Comments

@nshahan
Copy link
Contributor

nshahan commented Aug 29, 2023

The names for the build targets for DDC are changing. When this Dart SDK change gets rolled into Flutter the names should be updated here:

https://github.com/flutter/engine/blob/45e2b41e5ae5563afbfaca45d873451a6962d8a3/web_sdk/BUILD.gn#L142-L143
https://github.com/flutter/engine/blob/45e2b41e5ae5563afbfaca45d873451a6962d8a3/web_sdk/BUILD.gn#L193-L194
@nshahan nshahan added engine flutter/engine repository. See also e: labels. dependency: dart Dart team may need to help us labels Aug 29, 2023
@nshahan nshahan self-assigned this Aug 29, 2023
@nshahan nshahan mentioned this issue Sep 1, 2023
Merged
@chinmaygarde chinmaygarde added team-engine Owned by Engine team team-web Owned by Web platform team and removed team-engine Owned by Engine team labels Sep 5, 2023
nshahan added a commit to flutter/engine that referenced this issue Sep 6, 2023
@nshahan
Update deps on DDC build targets (#45404)
b04c2a3 
Update deps to use the new Dart SDK DDC build targets introduced in
these changes:
 - https://dart-review.googlesource.com/c/sdk/+/313081
 - https://dart-review.googlesource.com/c/sdk/+/315561

Fixes: flutter/flutter#133606
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@nshahan nshahan

Labels
dependency: dart Dart team may need to help us engine flutter/engine repository. See also e: labels. team-web Owned by Web platform team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update deps on DDC build targets nshahan/engine
2 participants
@chinmaygarde @nshahan