Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged-in PR not showing in dashboard #135518

Closed
1 task done
vashworth opened this issue Sep 26, 2023 · 4 comments · Fixed by flutter/cocoon#3106
Closed
1 task done

Merged-in PR not showing in dashboard #135518

vashworth opened this issue Sep 26, 2023 · 4 comments · Fixed by flutter/cocoon#3106
Assignees
@ricardoamador
Labels
team-infra Owned by Infrastructure team

Comments

@vashworth
Copy link
Contributor

vashworth commented Sep 26, 2023 •
edited

Is there an existing issue for this?

Type of Request

bug

Infrastructure Environment

LUCI

What is happening?

I have a PR (#135444) that merged at 12:48 CDT, but it isn't showing in the dashboard as of 2 PM CDT

One thing that may be of note is that I manually overrode the Google Testing status

Steps to reproduce

  1. Visit https://flutter-dashboard.appspot.com/#/build
  2. See that my PR is not listed

Expected results

I expect to see my PR in https://flutter-dashboard.appspot.com/#/build
@vashworth vashworth added the team-infra Owned by Infrastructure team label Sep 26, 2023
@vashworth
Copy link
Contributor Author

It just started showing on the dashboard at ~2:05 PM CDT

@keyonghan
Copy link
Contributor

There seems a bug in webhook subscription when GOB commit copy over is slow (fails to show up even after 3 retries), it will fail to insert the data to datastore. To workaround, I manually vacuum the missing commits.

@keyonghan
Copy link
Contributor

The webhook message is supposed to be resent to subscription API after 500 error, but it didn't. This causes the commit missing if GOB copybara slows.

I am trying to understand the difference between subscriptions github-webhooks-sub and luci-postsubmit:

where the webhook message was not retried after 500 but the postsubmit message did get retries

@ricardoamador ricardoamador mentioned this issue Sep 26, 2023
Merged
auto-submit bot pushed a commit to flutter/cocoon that referenced this issue Sep 26, 2023
@ricardoamador
Revert "Add a retry for checking for the GoB commit after PR merged" (#…
f0bf440 
…3106)

Reverts #3042

Fixes flutter/flutter#135518

This was preventing messages from being processed as if copybara is latent we can get in a loop of retrying for the commit while blocking reprocessing from pubsub. This will result in unacked messages and will cause them to be retried on exponential backoff.

![before_retry_removal](https://github.com/flutter/cocoon/assets/32242716/5641f9c1-62ee-4704-93ca-47cf9bf8a510)

Removing the retry we can see that the unacked messages are being retried now as we are not passing the ack deadline.

![image](https://github.com/flutter/cocoon/assets/32242716/071d8882-d3c2-4b1b-9178-7464180c985e)
@ricardoamador ricardoamador self-assigned this Sep 27, 2023
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ricardoamador ricardoamador

Labels
team-infra Owned by Infrastructure team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert "Add a retry for checking for the GoB commit after PR merged" flutter/cocoon
3 participants
@vashworth @ricardoamador @keyonghan