Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Impeller] Android device that successfully falls back to GLES renderer will print several warning messages #136059

Closed
jonahwilliams opened this issue Oct 6, 2023 · 4 comments
Labels
e: impeller Impeller rendering backend issues and features requests good first issue Relatively approachable for first-time contributors P2 Important issues not at the top of the work list team-engine Owned by Engine team triaged-engine Triaged by Engine team

Comments

@jonahwilliams
Copy link
Member

E/flutter ( 6908): [ERROR:flutter/impeller/base/validation.cc(49)] Break on 'ImpellerValidationBreak' to inspect point of failure: No valid Vulkan device found.
E/flutter ( 6908): [ERROR:flutter/shell/platform/android/android_context_vulkan_impeller.cc(48)] Using the Impeller rendering backend (Vulkan).
E/flutter ( 6908): [ERROR:flutter/shell/platform/android/android_context_gl_impeller.cc(80)] Using the Impeller rendering backend (OpenGLES).

We should not print "Using the Impeller rendering backend (Vulkan)." if we end up using GLES and make sure that the validation message does not print either

This was tested on a wembly.

@jonahwilliams jonahwilliams added e: impeller Impeller rendering backend issues and features requests team-engine Owned by Engine team labels Oct 6, 2023
@chinmaygarde
Copy link
Member

As a quick fix, there is an impeller::ScopedValidationDisable we can add to the scope that does the fallback to suppress these as messages. We add these to unit-tests to suppress validation chatter.

Just a generic message that says "tried to use Vulkan and OpenGL but both failed." or something similar.

@chinmaygarde chinmaygarde added good first issue Relatively approachable for first-time contributors P2 Important issues not at the top of the work list triaged-engine Triaged by Engine team labels Oct 7, 2023
@Rohithgilla12
Copy link

@chinmaygarde I want to give this a try, which is a good place to get started for this issue?

@jonahwilliams
Copy link
Member Author

Fixed in flutter/engine#51071

Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
e: impeller Impeller rendering backend issues and features requests good first issue Relatively approachable for first-time contributors P2 Important issues not at the top of the work list team-engine Owned by Engine team triaged-engine Triaged by Engine team
Projects
No open projects
Status: 🎨 OpenGL
Development

No branches or pull requests

3 participants