Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add swift tests for the flutter framework #137368

Open
gaaclarke opened this issue Oct 26, 2023 · 2 comments
Open

Add swift tests for the flutter framework #137368

gaaclarke opened this issue Oct 26, 2023 · 2 comments
Labels
a: tests "flutter test", flutter_test, or one of our tests c: proposal A detailed proposal for a change to Flutter engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list platform-ios iOS applications specifically team-ios Owned by iOS platform team triaged-ios Triaged by iOS platform team

Comments

@gaaclarke
Copy link
Member

#118832 found an issue which manifests only if you are writing against the flutter framework with swift. There currently is no test harness that builds against the implicit swift interface. We should add one so that we can assert we don't again somehow change the objc interface in a way that it breaks swift usage.

cc @hellohuanlin
@gaaclarke gaaclarke added platform-ios iOS applications specifically engine flutter/engine repository. See also e: labels. labels Oct 26, 2023
@gaaclarke gaaclarke mentioned this issue Oct 26, 2023
Merged
8 tasks
@danagbemava-nc danagbemava-nc added team-ios Owned by iOS platform team a: tests "flutter test", flutter_test, or one of our tests c: proposal A detailed proposal for a change to Flutter labels Oct 30, 2023
@cyanglaz cyanglaz added P1 High-priority issues at the top of the work list triaged-ios Triaged by iOS platform team labels Oct 30, 2023
@cyanglaz
Copy link
Contributor

cc @stuartmorgan

@jmagman jmagman added P2 Important issues not at the top of the work list and removed P1 High-priority issues at the top of the work list labels Jan 9, 2024
@jmagman
Copy link
Member

jmagman commented Mar 7, 2024

Filed #144791 to evaluate what's needed to get the Swift toolchain stuff into the engine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a: tests "flutter test", flutter_test, or one of our tests c: proposal A detailed proposal for a change to Flutter engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list platform-ios iOS applications specifically team-ios Owned by iOS platform team triaged-ios Triaged by iOS platform team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jmagman @cyanglaz @gaaclarke @danagbemava-nc