Made FlutterTaskQueue visible for Swift. #47348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
platform-ios
affects: desktop
platform-macos
e: impeller
labels
gaaclarke
force-pushed
the
task-queue-swift
branch
from
fff13db
to
3736098
Compare
gaaclarke
force-pushed
the
task-queue-swift
branch
3 times, most recently
from
443402d
to
e0a6450
Compare
gaaclarke
force-pushed
the
task-queue-swift
branch
from
e0a6450
to
5664b90
Compare
|
We don't have infrastructure to test this currently. I added an issue for it: flutter/flutter#137368 |
| @@ -118,12 +118,16 @@ - (void)dispatch:(dispatch_block_t)block { | |||
| FlutterBinaryMessageHandler handler, | |||
| NSObject<FlutterTaskQueue>* task_queue) { | |||
| FML_CHECK(platform_task_runner_->RunsTasksOnCurrentThread()); | |||
| // Use `respondsToSelector` instead of `conformsToProtocol` to accomodate | |||
| // hacking in your own `FlutterTaskQueue`. | |||
There was a problem hiding this comment.
can you explain more about "hacking in your own FlutterTaskQueue?
There was a problem hiding this comment.
done, injecting is a better description
|
|
||
| #import "flutter/shell/platform/darwin/common/framework/Headers/FlutterBinaryMessenger.h" | ||
|
|
||
| @protocol FlutterTaskQueueDispatch <FlutterTaskQueue> |
There was a problem hiding this comment.
can you add some comments on why we need FlutterTaskQueueDispatch?
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 27, 2023
fluttermirroringbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 27, 2023
…137442) flutter/engine@0bba9ee...1e66c0a 2023-10-27 30870216+gaaclarke@users.noreply.github.com Made FlutterTaskQueue visible for Swift. (flutter/engine#47348) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes flutter/flutter#118832
This makes the
FlutterTaskQueueprotocol visible, but keeps thedispatch:selector private. Under the covers there are runtime checks to make suredispatch:is available since we can't have compile time checks anymore.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.