Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web:multi-view] Build a non-singleton FlutterView implementation #137447

Closed
yjbanov opened this issue Oct 27, 2023 · 1 comment
Closed

[web:multi-view] Build a non-singleton FlutterView implementation #137447

yjbanov opened this issue Oct 27, 2023 · 1 comment
Assignees
Labels
P1 High-priority issues at the top of the work list platform-web Web applications specifically team-web Owned by Web platform team triaged-web Triaged by Web platform team

Comments

@yjbanov
Copy link
Contributor

yjbanov commented Oct 27, 2023

To support multi-view we need an implementation of FlutterView that we can instantiate multiple times and embed multiple of them onto the same page simultaneously. This implementation will combine together the underlying engine components (Renderer, PointerBinding, semantics, etc) and glue them to the public embedding API.

@yjbanov yjbanov added platform-web Web applications specifically P1 High-priority issues at the top of the work list team-web Owned by Web platform team triaged-web Triaged by Web platform team labels Oct 27, 2023
@mdebbar mdebbar self-assigned this Nov 16, 2023
auto-submit bot pushed a commit to flutter/engine that referenced this issue Nov 17, 2023
- `FlutterViewEmbedder` doesn't create the DOM tree anymore (instead, `DomManager` does).
- `DomManager` only creates the DOM tree (with styles) but doesn't insert it into the document.
- `EngineFlutterView` takes the root element from `DomManager` and inserts it into the document.
- We finally can now create multiple Flutter views, each with its own DOM tree.

cc @yjbanov since I'm making a few changes that probably conflict with your semantics changes.

Part of flutter/flutter#134443
Part of flutter/flutter#137447
@mdebbar mdebbar closed this as completed Nov 22, 2023
Copy link

github-actions bot commented Dec 6, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P1 High-priority issues at the top of the work list platform-web Web applications specifically team-web Owned by Web platform team triaged-web Triaged by Web platform team
Projects
None yet
Development

No branches or pull requests

2 participants