Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flutter Gallery Animation glitching Error #13817

Closed
braulio94 opened this issue Dec 31, 2017 · 16 comments
Closed

Flutter Gallery Animation glitching Error #13817

braulio94 opened this issue Dec 31, 2017 · 16 comments
Assignees
Labels
e: device-specific Only manifests on certain devices engine flutter/engine repository. See also e: labels.

Comments

@braulio94
Copy link
Contributor

braulio94 commented Dec 31, 2017

I installed flutter_gallery and got this glitching error

IDE: Android Studio 3.0.1
Device: Samsung Galaxy A5 (2016), with Android 7.0

Flutter Version:
Flutter channel master https://github.com/flutter/flutter.git
Framework revision 4d2c2aaaa1 (4 days ago) • 2017-12-27 07:30:31 -0800
Engine revision 7c126001d8
Tools Dart 1.25.0-dev.11.0

see video

@braulio94 braulio94 changed the title Flutter Gallery Animation Glishing Error Flutter Gallery Animation glitching Error Dec 31, 2017
@Hixie Hixie added dependency: skia Skia team may need to help us engine flutter/engine repository. See also e: labels. labels Jan 2, 2018
@Hixie Hixie added this to the 3: Current Milestone milestone Jan 2, 2018
@Hixie Hixie added e: device-specific Only manifests on certain devices and removed dependency: skia Skia team may need to help us labels Jan 2, 2018
@Hixie
Copy link
Contributor

Hixie commented Jan 2, 2018

@cbracken
Copy link
Member

cbracken commented Jan 4, 2018

@braulio94 Are all glitches you see text-related, or do you see other issues? Based on the screenshots and videos that appears to be the case. From the video, it looks like this only happens during animation, but I notice that the app bar headings are glitchy in the typography/colour screenshots too -- are there particular conditions where you see this?

@braulio94
Copy link
Contributor Author

@cbracken This happens to texts and icons, nothing else. The glitching starts every time I open the animation screen, then the rest gets affected.

@Hixie Hixie added this to To Do in Milestone 3 Jan 26, 2018
@Hixie Hixie moved this from To Do to Engine in Milestone 3 Jan 26, 2018
@cbracken
Copy link
Member

cbracken commented Jan 31, 2018

@braulio94 Now that https://skia-review.googlesource.com/c/skia/+/71780 has landed in Skia, which was rolled into the engine in flutter/engine#4364, and rolled into the framework in #13033, could you verify if you're still seeing this?

@braulio94
Copy link
Contributor Author

I have to upgrade flutter first, this could take some time. I'll do that then give you some feedback.

@braulio94
Copy link
Contributor Author

@cbracken it seems like nothing has changed see video

@cbracken
Copy link
Member

cbracken commented Jan 31, 2018

@braulio94 Based on the video, looks like this repros on an emulator. That's very helpful to know. Thanks for confirming; I'll keep this open then. Also on re-looking at the fix, it was iOS-specific so it wouldn't have helped on an Android device -- sorry about that oversight. We'll follow up on this.

@braulio94
Copy link
Contributor Author

@cbracken it's not an emulator #14385

@cbracken
Copy link
Member

cbracken commented Feb 5, 2018

Thanks for clarifying; I misunderstood what I was seeing (I spend most of my time dealing with iOS).

We'll follow up with Skia. Sounds like the root cause may be the same as the Skia issue around multi-texturing that was fixed for iOS by the patch I mentioned.

@braulio94
Copy link
Contributor Author

this could be something you'd also want to take a look at.

image

@cbracken
Copy link
Member

cbracken commented Feb 14, 2018

@braulio94 I've rolled a new version of Skia to the framework. This version includes some (non-platform-specific) fixes related to this, and re-enables multitexturing on iOS (it was never disabled on Android). I'm able to verify that I'm no longer seeing the issue on iOS.

I don't have an Android device that shows the issues you're seeing on the Samsung A5, but I'll look at getting one ordered. In the meantime, if you get a moment to check, would you mind checking if you still see the issues above on the master branch?

@cbracken
Copy link
Member

Tentatively closing since we're no longer able to reproduce this on any device we have that had this issue. @braulio94 since we don't have a Samsung A5, please let us know if you're still seeing this on that device and we'll re-open and follow-up.

Milestone 3 automation moved this from Engine (asiva, chinmay) to Done Feb 23, 2018
@cbracken cbracken removed this from Done in Milestone 3 Feb 23, 2018
@Chris1234567899
Copy link

I still experience this behavior in the gallery app (V 0.4.2). I have a Lenovo Vibe K5 with Android 5.1.1.

screenshot_2018-05-10-20-15-43

screenshot_2018-05-10-20-16-04

@zoechi
Copy link
Contributor

zoechi commented May 11, 2018

@Chris1234567899 I think it's better to create a new issue, this one is closed since a while and your issue might be a different one.
Please also add the output of flutter doctor

@Chris1234567899
Copy link

ok will do

@github-actions
Copy link

github-actions bot commented Sep 3, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
e: device-specific Only manifests on certain devices engine flutter/engine repository. See also e: labels.
Projects
None yet
Development

No branches or pull requests

5 participants