Roll Skia to f802e757646f424b563fdc1f5b5ee3c677659e98 #4670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rolling to tip of tree, but specifically the intent is to pick up fc4f768 in order to pick up a fix for multitexturing on iOS. Originally disabled in flutter#4364 due to iOS text rendering issues described in flutter/flutter#12934. Upstream Skia patch: https://skia-review.googlesource.com/c/skia/+/99800
jason-simmons
approved these changes
Feb 13, 2018
|
Shot-in-the-dark mostly for-cross-ref purposes: may improve flutter/flutter#13817 |
cbracken
added a commit
to cbracken/flutter_engine
that referenced
this pull request
Feb 14, 2018
This didn't break anything that we know of, but the engine is not currently rollable to the framework due to a Dart bug. I'm reverting this so we can get a fix landed for the Dart SDK, then roll, then re-land this, then roll, to allow us to measure the performance impact of the Dart SDK roll and the Skia roll independently. This reverts commit 94ce14f.
cbracken
added a commit
that referenced
this pull request
Feb 14, 2018
This didn't break anything that we know of, but the engine is not currently rollable to the framework due to a Dart bug. I'm reverting this so we can get a fix landed for the Dart SDK, then roll, then re-land this, then roll, to allow us to measure the performance impact of the Dart SDK roll and the Skia roll independently. This reverts commit 94ce14f.
cbracken
added a commit
to cbracken/flutter_engine
that referenced
this pull request
Feb 14, 2018
Rolling to tip of tree, but specifically the intent is to pick up fc4f768 in order to pick up a fix for multitexturing on iOS. Originally disabled in flutter#4364 due to iOS text rendering issues described in flutter/flutter#12934. Upstream Skia patch: https://skia-review.googlesource.com/c/skia/+/99800
cbracken
added a commit
to cbracken/flutter_engine
that referenced
this pull request
Feb 14, 2018
Rolling to tip of tree, but specifically the intent is to pick up fc4f768 in order to pick up a fix for multitexturing on iOS. Originally disabled in flutter#4364 due to iOS text rendering issues described in flutter/flutter#12934. Upstream Skia patch: https://skia-review.googlesource.com/c/skia/+/99800
cbracken
added a commit
that referenced
this pull request
Feb 14, 2018
Rolling to tip of tree, but specifically the intent is to pick up fc4f768 in order to pick up a fix for multitexturing on iOS. Originally disabled in #4364 due to iOS text rendering issues described in flutter/flutter#12934. Upstream Skia patch: https://skia-review.googlesource.com/c/skia/+/99800
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rolling to tip of tree, but specifically the intent is to pick up
fc4f768 in order to pick up a fix for
multitexturing on iOS. Originally disabled in #4364 due to
iOS text rendering issues described in flutter/flutter#12934.
Upstream Skia patch:
https://skia-review.googlesource.com/c/skia/+/99800