Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roll Skia to f802e757646f424b563fdc1f5b5ee3c677659e98 #4670

Merged
merged 2 commits into from
Feb 14, 2018

Conversation

cbracken
Copy link
Member

Rolling to tip of tree, but specifically the intent is to pick up
fc4f768 in order to pick up a fix for
multitexturing on iOS. Originally disabled in #4364 due to
iOS text rendering issues described in flutter/flutter#12934.

Upstream Skia patch:
https://skia-review.googlesource.com/c/skia/+/99800

Rolling to tip of tree, but specifically the intent is to pick up
fc4f768 in order to pick up a fix for
multitexturing on iOS. Originally disabled in flutter#4364 due to
iOS text rendering issues described in flutter/flutter#12934.

Upstream Skia patch:
https://skia-review.googlesource.com/c/skia/+/99800
@cbracken
Copy link
Member Author

cbracken commented Feb 13, 2018

Shot-in-the-dark mostly for-cross-ref purposes: may improve flutter/flutter#13817

@cbracken cbracken merged commit 94ce14f into flutter:master Feb 14, 2018
@cbracken cbracken deleted the roll-skia branch February 14, 2018 00:01
cbracken added a commit to cbracken/flutter_engine that referenced this pull request Feb 14, 2018
This didn't break anything that we know of, but the engine is not
currently rollable to the framework due to a Dart bug. I'm reverting
this so we can get a fix landed for the Dart SDK, then roll, then
re-land this, then roll, to allow us to measure the performance impact
of the Dart SDK roll and the Skia roll independently.

This reverts commit 94ce14f.
cbracken added a commit that referenced this pull request Feb 14, 2018
This didn't break anything that we know of, but the engine is not
currently rollable to the framework due to a Dart bug. I'm reverting
this so we can get a fix landed for the Dart SDK, then roll, then
re-land this, then roll, to allow us to measure the performance impact
of the Dart SDK roll and the Skia roll independently.

This reverts commit 94ce14f.
cbracken added a commit to cbracken/flutter_engine that referenced this pull request Feb 14, 2018
Rolling to tip of tree, but specifically the intent is to pick up
fc4f768 in order to pick up a fix for
multitexturing on iOS. Originally disabled in flutter#4364 due to
iOS text rendering issues described in flutter/flutter#12934.

Upstream Skia patch:
https://skia-review.googlesource.com/c/skia/+/99800
cbracken added a commit to cbracken/flutter_engine that referenced this pull request Feb 14, 2018
Rolling to tip of tree, but specifically the intent is to pick up
fc4f768 in order to pick up a fix for
multitexturing on iOS. Originally disabled in flutter#4364 due to
iOS text rendering issues described in flutter/flutter#12934.

Upstream Skia patch:
https://skia-review.googlesource.com/c/skia/+/99800
cbracken added a commit that referenced this pull request Feb 14, 2018
Rolling to tip of tree, but specifically the intent is to pick up
fc4f768 in order to pick up a fix for
multitexturing on iOS. Originally disabled in #4364 due to
iOS text rendering issues described in flutter/flutter#12934.

Upstream Skia patch:
https://skia-review.googlesource.com/c/skia/+/99800
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants