Add version numbers to flutter daemon/flutter run --machine #13933
Labels
c: new feature
Nothing broken; request for a new capability
tool
Affects the "flutter" command-line tool. See also t: labels.
Comments
Hixie
added
c: new feature
engine-flutter-autoroll
added a commit
that referenced
this issue
Dec 3, 2019
git@github.com:flutter/engine.git/compare/8672e79af873...faa1121 git log 8672e79..faa1121 --first-parent --oneline 2019-12-03 liyuqian@google.com Run benchmarks in Cirrus (#13950) 2019-12-03 stuartmorgan@google.com Report backing store changes in the macOS view (#13933) 2019-12-03 franciscojma@google.com Listen to keyUp event on meta modified keys (#13984) 2019-12-02 dnfield@google.com Fix live region logic (#14081) 2019-12-02 skia-flutter-autoroll@skia.org Roll src/third_party/skia e8c96d8e6116..2792515dab7c (1 commits) (#14069) 2019-12-02 bkonyi@google.com Roll src/third_party/dart 3f32196958..e4344a568f (1 commits) (#14073) 2019-12-02 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from aVdHP... to 6QxEZ... (#14080) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
jmagman
added this to Awaiting triage
in Tools - command line usability review
via automation
|
@DanTup It looks like the tool can now print machine readable version info. Is that sufficient to address this? |
zanderso
moved this from Awaiting triage
to Engineer reviewed
in Tools - command line usability review
|
Yeah - #17873 address this (though the above is a bit confused, since it's the protocol version rather than the Flutter version we use for things like emulator support). The main Flutter SDK version is read from the VERSION file to include in logs and things. So I don't think anything else is needed here. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The analysis server sends its version number in a "connected" event at startup. This is both useful for debugging if someone sends a log file but also for enabling functionality only when it's known to be supported.
It would be useful if
flutter run --machine/flutter daemondid the same. That way if there's new functionality in future (for example, the ability to launch emulators) the client can avoid sending unknown commands to older versions.I know it's possible to run
flutter --version, but relying on users to do this is error-prone (their PATH not match the flutter path they've set for the IDE) and it feels a bit naff for the IDEs to have to it separately.The text was updated successfully, but these errors were encountered: