Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dart compile wasm instead of directly invoking dart2wasm snapshot. #139579

Closed
eyebrowsoffire opened this issue Dec 5, 2023 · 3 comments
Closed

Use dart compile wasm instead of directly invoking dart2wasm snapshot. #139579

eyebrowsoffire opened this issue Dec 5, 2023 · 3 comments
Labels
e: wasm Issues related to the wasm build of Flutter Web. P2 Important issues not at the top of the work list r: fixed Issue is closed as already fixed in a newer version team-tool Owned by Flutter Tool team tool Affects the "flutter" command-line tool. See also t: labels. triaged-tool Triaged by Flutter Tool team

Comments

@eyebrowsoffire
Copy link
Contributor

Now that dart compile wasm is a thing, we should use that instead of directly invoking the dart2wasm snapshot and wasm-opt in the flutter tool.
@eyebrowsoffire eyebrowsoffire added tool Affects the "flutter" command-line tool. See also t: labels. e: wasm Issues related to the wasm build of Flutter Web. labels Dec 5, 2023
@danagbemava-nc danagbemava-nc added the team-tool Owned by Flutter Tool team label Dec 7, 2023
@christopherfujino christopherfujino added P2 Important issues not at the top of the work list triaged-tool Triaged by Flutter Tool team labels Jan 5, 2024
@eyebrowsoffire
Copy link
Contributor Author

Martin actually fixed this in this PR: #143298

1 similar comment
@eyebrowsoffire
Copy link
Contributor Author

Martin actually fixed this in this PR: #143298

@danagbemava-nc danagbemava-nc added the r: fixed Issue is closed as already fixed in a newer version label Feb 22, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2024

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
e: wasm Issues related to the wasm build of Flutter Web. P2 Important issues not at the top of the work list r: fixed Issue is closed as already fixed in a newer version team-tool Owned by Flutter Tool team tool Affects the "flutter" command-line tool. See also t: labels. triaged-tool Triaged by Flutter Tool team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@christopherfujino @eyebrowsoffire @danagbemava-nc