Collect metrics on mac builds when running without goma #140342
Labels
P2
Important issues not at the top of the work list
team-infra
Owned by Infrastructure team
triaged-infra
Triaged by Infrastructure team
Comments
8 tasks
auto-submit bot
pushed a commit
to flutter/engine
that referenced
this issue
Dec 19, 2023
This is to prevent builds from timing out during the experiment to disable goma on mac post submit builds. Bug: flutter/flutter#140342 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
keyonghan
added
triaged-infra
XuanTung95
pushed a commit
to XuanTung95/recipes
that referenced
this issue
Feb 14, 2024
This is to collect benchmarks of how big the impact of not using goma for mac builds in prod. Bug: flutter/flutter#140342 Change-Id: Ida97dff28bf46906417dffbdbfd2a163363778e5 Reviewed-on: https://flutter-review.googlesource.com/c/recipes/+/53260 Reviewed-by: Yusuf Mohsinally <mohsinally@google.com> Commit-Queue: Godofredo Contreras <godofredoc@google.com> Reviewed-by: Keyong Han <keyonghan@google.com>
XuanTung95
pushed a commit
to XuanTung95/recipes
that referenced
this issue
Feb 14, 2024
This reverts commit 338427c. Reason for revert: This was a temporary test to run builds without using goma. Its time to go back. Original change's description: > Do not use goma for mac prod builds. > > This is to collect benchmarks of how big the impact of not using goma > for mac builds in prod. > > Bug: flutter/flutter#140342 > Change-Id: Ida97dff28bf46906417dffbdbfd2a163363778e5 > Reviewed-on: https://flutter-review.googlesource.com/c/recipes/+/53260 > Reviewed-by: Yusuf Mohsinally <mohsinally@google.com> > Commit-Queue: Godofredo Contreras <godofredoc@google.com> > Reviewed-by: Keyong Han <keyonghan@google.com> # Not skipping CQ checks because original CL landed > 1 day ago. Bug: flutter/flutter#140342 Change-Id: Ie8696fab8307ae32e1d4face529d2f94d7d2e968 Reviewed-on: https://flutter-review.googlesource.com/c/recipes/+/53423 Reviewed-by: Yusuf Mohsinally <mohsinally@google.com> Reviewed-by: Godofredo Contreras <godofredoc@google.com> Commit-Queue: Yusuf Mohsinally <mohsinally@google.com>
|
@yusuf-goog can we update this bug with the results of the validation and close? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Type of Request
infra task
Infrastructure Environment
goma, builds
What is happening?
We need to determine the impact on build times for mac engine builders that generate artifacts, when they do not use goma.
The requirement to collect this data has been laid out in an internal document.
Additional details to follow below.
Steps to reproduce
No response
Expected results
No response
The text was updated successfully, but these errors were encountered: