Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename MemoryAllocations to FlutterMemoryAllocations. #140622

Open
5 of 6 tasks
polina-c opened this issue Dec 26, 2023 · 0 comments
Open
5 of 6 tasks

Rename MemoryAllocations to FlutterMemoryAllocations. #140622

polina-c opened this issue Dec 26, 2023 · 0 comments
Assignees
@polina-c
Labels
a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker c: new feature Nothing broken; request for a new capability

Comments

@polina-c
Copy link
Contributor

polina-c commented Dec 26, 2023 •
edited

Why?

Disposables in Dart cannot use MemoryAllocations in Flutter. So, to be leak trackable they need a dart-only class.
See detains in the document.

Why now?

  1. We want early adopters of leak tracker (for example, package owners) to use the class with the right name, so that they do not deal with renaming later.
  2. It will take time for the renaming to land to flutter stable.

Steps:

  • Add FlutterMemoryAllocations and deprecate MemoryAllocations in Flutter
  • Document breaking change in Flutter: Describe breaking change. website#10021
  • Update leak tracker to use FlutterMemoryAllocations
  • Roll leak tracker to G3
  • Upgrade flutter to new leak tracker
  • Remove MemoryAllocations from Flutter
@polina-c polina-c self-assigned this Dec 26, 2023
@polina-c polina-c added the a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker label Dec 26, 2023
This was referenced Dec 26, 2023
Open
Merged
polina-c added a commit that referenced this issue Jan 2, 2024
@polina-c
Rename MemoryAllocations to FlutterMemoryAllocations. (#140623)
f667376 
Contributes to #140622
victoreronmosele pushed a commit to victoreronmosele/flutter that referenced this issue Jan 6, 2024
@polina-c @victoreronmosele
Rename MemoryAllocations to FlutterMemoryAllocations. (flutter#140623)
8ed4c2d 
Contributes to flutter#140622
Michal-MK pushed a commit to Michal-MK/flutter that referenced this issue Jan 8, 2024
@polina-c @Michal-MK
Rename MemoryAllocations to FlutterMemoryAllocations. (flutter#140623)
58bf8e8 
Contributes to flutter#140622
Markzipan pushed a commit to Markzipan/flutter that referenced this issue Jan 9, 2024
@polina-c @Markzipan
Rename MemoryAllocations to FlutterMemoryAllocations. (flutter#140623)
51ed3bd 
Contributes to flutter#140622
@polina-c polina-c mentioned this issue Jan 9, 2024
Merged
3 tasks
@polina-c polina-c changed the title Rename MemoryAllocations to FlutterMemoryAllocations Rename MemoryAllocations to FlutterMemoryAllocations. Jan 9, 2024
@polina-c polina-c added the c: new feature Nothing broken; request for a new capability label Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@polina-c polina-c

Labels
a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker c: new feature Nothing broken; request for a new capability
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@polina-c