Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skwasm] Disabled ActionChip with label and avatar fails to render contents #140999

Closed
parlough opened this issue Jan 5, 2024 · 1 comment · Fixed by flutter/engine#50928
Closed
Assignees
Labels
e: web_skwasm Skwasm rendering backend for web engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list platform-web Web applications specifically team-web Owned by Web platform team triaged-web Triaged by Web platform team

Comments

@parlough
Copy link
Member

parlough commented Jan 5, 2024

The following snippet creates a disabled ActionChip (or InputChip) with an icon and a label.

import 'package:flutter/material.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return const MaterialApp(
      home: Scaffold(
        body: Center(
          child: ActionChip(
            avatar: Icon(Icons.account_circle),
            label: Text('Test'),
          ),
        ),
      ),
    );
  }
}
  1. Build with skwasm flutter build web --wasm --web-renderer=skwasm
  2. Serve with necessary flags (dart pub global run dhttpd --path=build/web_wasm --headers="Cross-Origin-Embedder-Policy=require-corp;Cross-Origin-Opener-Policy=same-origin")
  3. Visit the site on a recent version of Chrome (I'm using 122.0.6182.0)
  4. See that the chip has no contents.
  5. The contents are however visible if the chip is not disabled (by specifying an onPressed handler).

Result (skwasm):

Result with skwasm

Expected (CanvasKit):

Expected with CanvasKit

Version information

Flutter 3.18.0-19.0.pre.74 • channel main • https://github.com/flutter/flutter
Framework • revision 4ff2396b86 (42 minutes ago) • 2024-01-04 20:23:28 -0500
Engine • revision f2f00a438e
Tools • Dart 3.3.0 (build 3.3.0-279.0.dev) • DevTools 2.31.0
@parlough parlough added engine flutter/engine repository. See also e: labels. e: web_skwasm Skwasm rendering backend for web team-web Owned by Web platform team labels Jan 5, 2024
@parlough parlough added the platform-web Web applications specifically label Jan 5, 2024
@yjbanov yjbanov added P1 High-priority issues at the top of the work list triaged-web Triaged by Web platform team labels Jan 11, 2024
@yjbanov yjbanov added P2 Important issues not at the top of the work list and removed P1 High-priority issues at the top of the work list labels Feb 22, 2024
eyebrowsoffire added a commit to eyebrowsoffire/engine that referenced this issue Feb 23, 2024
@eyebrowsoffire eyebrowsoffire self-assigned this Feb 23, 2024
auto-submit bot pushed a commit to flutter/engine that referenced this issue Feb 26, 2024
This fixes flutter/flutter#140999. Previously, the cull rect would be misplaced causing many elements to not render at all.
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
e: web_skwasm Skwasm rendering backend for web engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list platform-web Web applications specifically team-web Owned by Web platform team triaged-web Triaged by Web platform team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants
@yjbanov @parlough @eyebrowsoffire and others