Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pointer_binding_test causes flakes in engine builds on Windows #142991

Closed
matanlurey opened this issue Feb 6, 2024 · 2 comments
Closed

pointer_binding_test causes flakes in engine builds on Windows #142991

matanlurey opened this issue Feb 6, 2024 · 2 comments
Labels
P0 Critical issues such as a build break or regression platform-web Web applications specifically team-web Owned by Web platform team

Comments

@matanlurey
Copy link
Contributor

Example: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8756873848269480001/+/u/test:_run_suite_chrome-dart2js-html-engine/stdout

00:11 +238 ~1 -1: pointer_binding_test.dart: ClickDebouncer Dedupes click if pointer down/up flushed recently [E]                                                                                      
  Expected: [
              PointerChange:PointerChange.add,
              PointerChange:PointerChange.down,
              PointerChange:PointerChange.up
            ]
    Actual: []
     Which: at location [0] is [] which shorter than expected
  Queued up events should be flushed to the framework because the time expired before the click event arrived.
  
  org-dartlang-sdk:///lib/_internal/js_runtime/lib/js_helper.dart 1195:19                      Object.wrapException
  org-dartlang-sdk:///lib/_internal/js_runtime/lib/js_helper.dart 1236:28                      Object.throwExpression
  home\chrome-bot\.pub-cache\hosted\pub.dev\matcher-0.12.16\lib\src\expect\expect.dart 149:31  Object.fail
  home\chrome-bot\.pub-cache\hosted\pub.dev\matcher-0.12.16\lib\src\expect\expect.dart 144:3   Object._expect
  home\chrome-bot\.pub-cache\hosted\pub.dev\matcher-0.12.16\lib\src\expect\expect.dart 56:3    Object.expect
  ..\..\..\..\flutter\lib\web_ui\test\engine\pointer_binding_test.dart 2891:5                  <fn>
  org-dartlang-sdk:///lib/_internal/js_runtime/lib/async_patch.dart 303:19                     _wrapJsFunctionForAsync.closure.$protected
  org-dartlang-sdk:///lib/_internal/js_runtime/lib/async_patch.dart 328:23                     _wrapJsFunctionForAsync.<fn>
  org-dartlang-sdk:///lib/_internal/js_runtime/lib/async_patch.dart 279:19                     _awaitOnObject.<fn>
  org-dartlang-sdk:///lib/async/zone.dart 1407:39          
@matanlurey matanlurey added platform-web Web applications specifically P0 Critical issues such as a build break or regression team-web Owned by Web platform team labels Feb 6, 2024
matanlurey added a commit to flutter/engine that referenced this issue Feb 6, 2024
@yjbanov
Copy link
Contributor

yjbanov commented Feb 6, 2024

Deduplicating into the existing #139334

@yjbanov yjbanov closed this as completed Feb 6, 2024
flutteractionsbot pushed a commit to flutteractionsbot/engine that referenced this issue Feb 6, 2024
flutteractionsbot pushed a commit to flutteractionsbot/engine that referenced this issue Feb 6, 2024
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P0 Critical issues such as a build break or regression platform-web Web applications specifically team-web Owned by Web platform team
Projects
None yet
Development

No branches or pull requests

2 participants