Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[reporting] GitHub check doesn't display special characters correctly #143162

Open
guidezpl opened this issue Feb 8, 2024 · 8 comments
Open

[reporting] GitHub check doesn't display special characters correctly #143162

guidezpl opened this issue Feb 8, 2024 · 8 comments
Labels
a: tests "flutter test", flutter_test, or one of our tests P2 Important issues not at the top of the work list team-infra Owned by Infrastructure team

Comments

@guidezpl
Copy link
Member

guidezpl commented Feb 8, 2024

Type of Request

bug

Infrastructure Environment

LUCI + Github

What is happening?

LUCI error output in GitHub doesn't display all characters correctly.

image in LUCI

looks like

image

in GitHub checks

Steps to reproduce

  1. Get a failed flutter-dashboard / LUCI check on a PR, e.g. https://github.com/flutter/flutter/pull/143130/checks?check_run_id=21348700368

Expected results

I expect to be able to see the LUCI output with correct characters
@guidezpl guidezpl added the team-infra Owned by Infrastructure team label Feb 8, 2024
@keyonghan keyonghan added P2 Important issues not at the top of the work list triaged-infra Triaged by Infrastructure team labels Feb 8, 2024
@godofredoc godofredoc added a: tests "flutter test", flutter_test, or one of our tests and removed team-infra Owned by Infrastructure team labels Mar 22, 2024
@flutter-triage-bot flutter-triage-bot bot removed the triaged-infra Triaged by Infrastructure team label Mar 23, 2024
@flutter-triage-bot
Copy link

The triaged-infra label is irrelevant if there is no team-infra label or fyi-infra label.

@darshankawar darshankawar added the will need additional triage This issue or PR needs attention during weekly triage label Mar 25, 2024
godofredoc added a commit to godofredoc/cocoon that referenced this issue Mar 26, 2024
@godofredoc
Add logging for the checks update output.
2f63d06 
This is to identify where the summary output is getting garbled.

Bug: flutter/flutter#143162
@godofredoc godofredoc mentioned this issue Mar 26, 2024
Merged
8 tasks
auto-submit bot pushed a commit to flutter/cocoon that referenced this issue Mar 26, 2024
@godofredoc
Add logging for the checks update output. (#3599)
f1e3418 
This is to identify where the summary output is getting garbled.

Bug: flutter/flutter#143162
@goderbauer goderbauer added team-infra Owned by Infrastructure team and removed will need additional triage This issue or PR needs attention during weekly triage labels Mar 26, 2024
godofredoc added a commit to godofredoc/cocoon that referenced this issue Mar 26, 2024
@godofredoc
Add more logs to identify where summary gets garbled.
ade1cb2 
The logs showed that once the output is sent to the checkrun update is
already garbled. We need to see the state of the data from LUCI and also
after the summary.

Bug: flutter/flutter#143162
@godofredoc godofredoc mentioned this issue Mar 26, 2024
Merged
8 tasks
auto-submit bot pushed a commit to flutter/cocoon that referenced this issue Mar 27, 2024
@godofredoc
Add more logs to identify where summary gets garbled. (#3600)
345034f 
The logs showed that once the output is sent to the checkrun update is already garbled. We need to see the state of the data from LUCI and also after the summary.

Bug: flutter/flutter#143162
godofredoc added a commit to godofredoc/cocoon that referenced this issue Mar 27, 2024
@godofredoc
Use utf-8 encoding on getbuild requests.
76ea797 
Dart uses latin1 encoding by default instead of utf-8 causing garbled
output in summary markdown. This change send the proper headers to get
utf-8 from server and decode utf from bytes before passing it to the
json decoder.

Bug: flutter/flutter#143162
@godofredoc godofredoc mentioned this issue Mar 27, 2024
Merged
8 tasks
auto-submit bot pushed a commit to flutter/cocoon that referenced this issue Mar 27, 2024
@godofredoc
Use utf-8 encoding on getbuild requests. (#3601)
a594edb 
Dart uses latin1 encoding by default instead of utf-8 causing garbled output in summary markdown. This change send the proper headers to get utf-8 from server and decode utf from bytes before passing it to the json decoder.

Bug: flutter/flutter#143162
@godofredoc
Copy link
Contributor

Similar issues:

@godofredoc
Copy link
Contributor

This is fixed now. Some examples:

@godofredoc
Copy link
Contributor

@Hixie @goderbauer @christopherfujino after two years, several fixes in test runners, bash/powershell script wrappers and backend services I am happy to announce the special characters are now being presented correctly in the GitHub UI.

@godofredoc
Copy link
Contributor

Recipes CL: https://flutter-review.googlesource.com/c/recipes/+/56720

@goderbauer
Copy link
Member

Nice! Should this issue be closed then? Or is there more to do?

@godofredoc godofredoc changed the title GitHub check doesn't display special characters correctly [reporting] GitHub check doesn't display special characters correctly Mar 28, 2024
@github-actions GitHub Actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2024
@guidezpl
Copy link
Member Author

Unfortunately, this seemed to have pop back up, reopening the issue.

https://github.com/flutter/flutter/pull/148408/checks?check_run_id=25001247171

image

@guidezpl guidezpl reopened this May 15, 2024
@flutter flutter unlocked this conversation May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a: tests "flutter test", flutter_test, or one of our tests P2 Important issues not at the top of the work list team-infra Owned by Infrastructure team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@goderbauer @guidezpl @godofredoc @keyonghan @darshankawar