Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Impeller] Migrate _NUM_EXPECTED_GENERATED_IMPELLER_GOLDEN_FILES to diff file #143353

Closed
gaaclarke opened this issue Feb 13, 2024 · 1 comment · Fixed by flutter/engine#50621
Closed

[Impeller] Migrate _NUM_EXPECTED_GENERATED_IMPELLER_GOLDEN_FILES to diff file #143353

gaaclarke opened this issue Feb 13, 2024 · 1 comment · Fixed by flutter/engine#50621
Labels
c: tech-debt Technical debt, code quality, testing, etc. e: impeller Impeller rendering backend issues and features requests team-engine Owned by Engine team

Comments

@gaaclarke
Copy link
Member

_NUM_EXPECTED_GENERATED_IMPELLER_GOLDEN_FILES is a stopgap that makes sure we don't lose tests. It however doesn't merge well when people simultaneously edit the files. We should switch to a system like the license checker that has a listing of the the generated files so that they can merge cleanly.
@gaaclarke gaaclarke added c: tech-debt Technical debt, code quality, testing, etc. e: impeller Impeller rendering backend issues and features requests team-engine Owned by Engine team labels Feb 13, 2024
@gaaclarke gaaclarke mentioned this issue Feb 13, 2024
Merged
8 tasks
auto-submit bot pushed a commit to flutter/engine that referenced this issue Feb 14, 2024
@gaaclarke
[Impeller] replaces golden file count with a golden diff file (#50621)
0849250 
fixes flutter/flutter#143353

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
@github-actions GitHub Actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
c: tech-debt Technical debt, code quality, testing, etc. e: impeller Impeller rendering backend issues and features requests team-engine Owned by Engine team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Impeller] replaces golden file count with a golden diff file gaaclarke/engine
1 participant
@gaaclarke