Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider including flutter.js.map in the build output folder #145111

Open
eyebrowsoffire opened this issue Mar 13, 2024 · 6 comments
Open

Consider including flutter.js.map in the build output folder #145111

eyebrowsoffire opened this issue Mar 13, 2024 · 6 comments
Labels
a: build Building flutter applications with the tool c: proposal A detailed proposal for a change to Flutter P2 Important issues not at the top of the work list platform-web Web applications specifically team-web Owned by Web platform team tool Affects the "flutter" command-line tool. See also t: labels. triaged-web Triaged by Web platform team

Comments

@eyebrowsoffire
Copy link
Contributor

Since we include flutter.js in the output build directory, it might be worthwhile to also include flutter.js.map by default.

@danagbemava-nc danagbemava-nc added in triage Presently being triaged by the triage team tool Affects the "flutter" command-line tool. See also t: labels. platform-web Web applications specifically c: proposal A detailed proposal for a change to Flutter a: build Building flutter applications with the tool team-web Owned by Web platform team and removed in triage Presently being triaged by the triage team labels Mar 14, 2024
@yjbanov yjbanov added P2 Important issues not at the top of the work list triaged-web Triaged by Web platform team labels Mar 21, 2024
@henryqum
Copy link

Hi, my flutter web app break on safari because it can't load flutter.js.map, i get Failed to load resource: the server responded with a status of 404 (), the browser manage to load all other files

@BenBroide
Copy link

BenBroide commented Jul 18, 2024

Same issue. Web app breaks on mobile browsers, even when adding flags flutter build web --release --source-maps the file flutter.js.map is not generated

@BenBroide
Copy link

Hi, my flutter web app break on safari because it can't load flutter.js.map, i get Failed to load resource: the server responded with a status of 404 (), the browser manage to load all other files

Could be something else is breaking your web app but the only error is the .map file error
In my case something else was breaking the app.
You can try by setting a placeholder map file and see which errors you have after

@henryqum
Copy link

In my case something else was breaking the app.

could be, what broke your app?

@BenBroide
Copy link

BenBroide commented Jul 18, 2024

In my case something else was breaking the app.

could be, what broke your app?

I moved some variables to a .env file and did not adjust git actions to set them while deploying.
Try to set this in your app as placeholder and see which error show up in console once the .map file error will be gone. The error will probably not show the exact code since it's not a real .map file

flutter.js.map

{
    "version": 3,
    "file": "flutter.js",
    "sources": [],
    "names": [],
    "mappings": ""
  }

@henryqum
Copy link

@BenBroide Sure, I'll try that. Thanks for your suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: build Building flutter applications with the tool c: proposal A detailed proposal for a change to Flutter P2 Important issues not at the top of the work list platform-web Web applications specifically team-web Owned by Web platform team tool Affects the "flutter" command-line tool. See also t: labels. triaged-web Triaged by Web platform team
Projects
None yet
Development

No branches or pull requests

5 participants